ci: verify managed run replay in workflow#17
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a24c5ffb5f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| terminal_status="$( | ||
| wait_for_managed_run_terminal "${RUN_ID}" "${WAIT_TIMEOUT_SECS}" "${POLL_MS}" | ||
| )" | ||
| echo "Run ${RUN_ID} reached terminal status: ${terminal_status}" >&2 |
There was a problem hiding this comment.
Fail --wait when managed run does not complete
In --wait mode the script captures terminal_status and logs it, but never enforces that the status is completed before continuing to hermes runs verify --strict. Because strict verification only checks Signet receipts/audit integrity (not run outcome), a replay that ends in failed, cancelled, or timed_out after emitting receipts can still make this step succeed, so the new workflow can report replay verification as green even when the replay execution itself failed.
Useful? React with 👍 / 👎.
777fcd6 to
7ad71d0
Compare
Summary
Why
This keeps the CI/example wiring in a separate review from the runtime changes, while still exercising the replay loop that the managed beta now supports.
Validation
bash -n examples/verify-managed-run.sh examples/replay-managed-run.sh examples/lib/managed-run-helpers.shbash examples/verify-managed-run.sh --helpbash examples/replay-managed-run.sh --helpNotes
main, so this PR only carries the workflow/examples/docs layer.