Never ts-nocheck (#1028)

- Add node flag "--experimental-strip-types" for "npm start"
- Refactor hanabi-bot to TypeScript and update ESLint configuration to get rid of the current only exception
- Add Node.js engine requirement ^22.6.0 to package.json and package-lock.json

Author: xkatianx

eslint.config.mjs

@@ -13,9 +13,7 @@ const compat = new FlatCompat({
 	allConfig: js.configs.all
 });
 
-export default [{
-	ignores: ["src/hanabi-bot.js"],
-}, ...compat.extends("eslint:recommended", "plugin:jsdoc/recommended"), {
+export default [...compat.extends("eslint:recommended", "plugin:jsdoc/recommended"), {
 	// plugins: {
 	// 	jsdoc,
 	// },

package-lock.json

@@ -10,10 +10,13 @@
     "typescript": "^5.6.3"
   },
   "scripts": {
-    "start": "node --env-file=.env src/hanabi-bot.js",
+    "start": "node --experimental-strip-types --env-file=.env src/hanabi-bot.ts",
     "replay": "node --env-file=.env src/replay.js",
     "self-play": "node --env-file=.env src/self-play.js",
     "lint": "eslint .",
     "test": "node --test"
+  },
+  "engines": {
+    "node": "^22.6.0"
   }
 }

package.json

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import * as https from 'https';
 
 import { handle } from './command-handler.js';
@@ -32,12 +31,12 @@ function connect(bot_index = '') {
 		}
 	};
 
-	return new Promise((resolve, reject) => {
+	return new Promise<string>((resolve, reject) => {
 		// Send login request to hanab.live
 		const req = https.request(options, (res) => {
 			console.log(`Request status code: ${res.statusCode}`);
 
-			const cookie = res.headers['set-cookie'][0];
+			const cookie = res.headers['set-cookie']?.[0];
 			if (cookie == null) {
 				reject('Failed to parse cookie from auth headers.');
 				return;
@@ -58,22 +57,16 @@ function connect(bot_index = '') {
 	});
 }
 
+declare var WebSocket: typeof import("undici-types").WebSocket;
+
 async function main() {
 	if (Number(process.versions.node.split('.')[0]) < 22)
 		throw new Error(`This program requires Node v22 or above! Currently using Node v${process.versions.node}.`);
 
 	const { index, manual } = Utils.parse_args();
 
-	let cookie = connect(index);
-
 	// Connect to server using credentials
-	try {
-		cookie = await cookie;
-	}
-	catch (error) {
-		console.error(error);
-		return;
-	}
+	const cookie = await connect(index);
 
 	// Establish websocket
 	const ws = new WebSocket(`wss://${HANABI_HOSTNAME}/ws`, { headers: { Cookie: cookie } });
@@ -91,7 +84,7 @@ async function main() {
 
 	ws.addEventListener('message', (event) => {
 		// Websocket messages are in the format: commandName {"field_name":"value"}
-		const str = event.data;
+		const str = event.data.toString();
 		const ind = str.indexOf(' ');
 		const [command, arg] = [str.slice(0, ind), str.slice(ind + 1)];
 
@@ -102,4 +95,4 @@ async function main() {
 	});
 }
 
-main();
+main().catch(console.error);

src/hanabi-bot.js src/hanabi-bot.ts

@@ -8,6 +8,6 @@
     "resolveJsonModule": true,
     "strict": false
   },
-  "include": ["src/**/*.js", "src/**/*.d.ts", "test/**/*.js"],
+  "include": ["src/**/*.js", "src/**/*.ts", "test/**/*.js"],
   "exclude": ["node_modules"]
 }