Use scoped pointer for Ui in plugins

hluk · hluk · commit 86a5caf06156 · 2014-03-15T18:15:44.000+01:00
diff --git a/plugins/itemdata/itemdata.cpp b/plugins/itemdata/itemdata.cpp
@@ -151,14 +151,8 @@ void ItemData::contextMenuEvent(QContextMenuEvent *e)
     e->ignore();
 }
 
-ItemDataLoader::ItemDataLoader()
-    : ui(NULL)
-{
-}
-
 ItemDataLoader::~ItemDataLoader()
 {
-    delete ui;
 }
 
 ItemWidget *ItemDataLoader::create(const QModelIndex &index, QWidget *parent) const
@@ -187,8 +181,7 @@ QVariantMap ItemDataLoader::applySettings()
 
 QWidget *ItemDataLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemDataSettings;
+    ui.reset(new Ui::ItemDataSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
 
diff --git a/plugins/itemdata/itemdata.h b/plugins/itemdata/itemdata.h
@@ -24,6 +24,7 @@
 #include "gui/icons.h"
 
 #include <QLabel>
+#include <QScopedPointer>
 
 namespace Ui {
 class ItemDataSettings;
@@ -58,8 +59,6 @@ class ItemDataLoader : public QObject, public ItemLoaderInterface
     Q_INTERFACES(ItemLoaderInterface)
 
 public:
-    ItemDataLoader();
-
     ~ItemDataLoader();
 
     virtual ItemWidget *create(const QModelIndex &index, QWidget *parent) const;
@@ -83,7 +82,7 @@ private slots:
 
 private:
     QVariantMap m_settings;
-    Ui::ItemDataSettings *ui;
+    QScopedPointer<Ui::ItemDataSettings> ui;
 };
 
 #endif // ITEMDATA_H
diff --git a/plugins/itemencrypted/itemencrypted.cpp b/plugins/itemencrypted/itemencrypted.cpp
@@ -117,7 +117,7 @@ void ItemEncrypted::setModelData(QWidget *editor, QAbstractItemModel *model,
 }
 
 ItemEncryptedLoader::ItemEncryptedLoader()
-    : ui(NULL)
+    : ui()
     , m_settings()
     , m_gpgProcessStatus(GpgNotRunning)
     , m_gpgProcess(NULL)
@@ -127,7 +127,6 @@ ItemEncryptedLoader::ItemEncryptedLoader()
 ItemEncryptedLoader::~ItemEncryptedLoader()
 {
     terminateGpgProcess();
-    delete ui;
 }
 
 ItemWidget *ItemEncryptedLoader::create(const QModelIndex &index, QWidget *parent) const
@@ -150,8 +149,7 @@ QVariantMap ItemEncryptedLoader::applySettings()
 
 QWidget *ItemEncryptedLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemEncryptedSettings;
+    ui.reset(new Ui::ItemEncryptedSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
 
diff --git a/plugins/itemencrypted/itemencrypted.h b/plugins/itemencrypted/itemencrypted.h
@@ -24,6 +24,7 @@
 #include "gui/icons.h"
 
 #include <QProcess>
+#include <QScopedPointer>
 #include <QWidget>
 
 namespace Ui {
@@ -97,7 +98,7 @@ private slots:
 
     void updateUi();
 
-    Ui::ItemEncryptedSettings *ui;
+    QScopedPointer<Ui::ItemEncryptedSettings> ui;
     QVariantMap m_settings;
 
     GpgProcessStatus m_gpgProcessStatus;
diff --git a/plugins/itemfakevim/itemfakevim.cpp b/plugins/itemfakevim/itemfakevim.cpp
@@ -531,14 +531,8 @@ QObject *ItemFakeVim::createExternalEditor(const QModelIndex &index, QWidget *pa
     return m_childItem->createExternalEditor(index, parent);
 }
 
-ItemFakeVimLoader::ItemFakeVimLoader()
-    : ui(NULL)
-{
-}
-
 ItemFakeVimLoader::~ItemFakeVimLoader()
 {
-    delete ui;
 }
 
 QVariant ItemFakeVimLoader::icon() const
@@ -563,8 +557,7 @@ void ItemFakeVimLoader::loadSettings(const QVariantMap &settings)
 
 QWidget *ItemFakeVimLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemFakeVimSettings;
+    ui.reset(new Ui::ItemFakeVimSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
 
diff --git a/plugins/itemfakevim/itemfakevim.h b/plugins/itemfakevim/itemfakevim.h
@@ -66,8 +66,6 @@ class ItemFakeVimLoader : public QObject, public ItemLoaderInterface
     Q_INTERFACES(ItemLoaderInterface)
 
 public:
-    ItemFakeVimLoader();
-
     ~ItemFakeVimLoader();
 
     virtual QString id() const { return "itemfakevim"; }
@@ -91,7 +89,7 @@ class ItemFakeVimLoader : public QObject, public ItemLoaderInterface
 private:
     bool m_enabled;
     QString m_sourceFileName;
-    Ui::ItemFakeVimSettings *ui;
+    QScopedPointer<Ui::ItemFakeVimSettings> ui;
 };
 
 #endif // ITEMFAKEVIM_H
diff --git a/plugins/itemimage/itemimage.cpp b/plugins/itemimage/itemimage.cpp
@@ -99,14 +99,8 @@ QObject *ItemImage::createExternalEditor(const QModelIndex &index, QWidget *pare
     return cmd.isEmpty() ? NULL : new ItemEditor(data, mime, cmd, parent);
 }
 
-ItemImageLoader::ItemImageLoader()
-    : ui(NULL)
-{
-}
-
 ItemImageLoader::~ItemImageLoader()
 {
-    delete ui;
 }
 
 ItemWidget *ItemImageLoader::create(const QModelIndex &index, QWidget *parent) const
@@ -137,7 +131,6 @@ QStringList ItemImageLoader::formatsToSave() const
 
 QVariantMap ItemImageLoader::applySettings()
 {
-    Q_ASSERT(ui != NULL);
     m_settings["max_image_width"] = ui->spinBoxImageWidth->value();
     m_settings["max_image_height"] = ui->spinBoxImageHeight->value();
     m_settings["image_editor"] = ui->lineEditImageEditor->text();
@@ -147,8 +140,7 @@ QVariantMap ItemImageLoader::applySettings()
 
 QWidget *ItemImageLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemImageSettings;
+    ui.reset(new Ui::ItemImageSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
     ui->spinBoxImageWidth->setValue( m_settings.value("max_image_width", 320).toInt() );
diff --git a/plugins/itemimage/itemimage.h b/plugins/itemimage/itemimage.h
@@ -24,6 +24,7 @@
 #include "item/itemwidget.h"
 
 #include <QLabel>
+#include <QScopedPointer>
 
 namespace Ui {
 class ItemImageSettings;
@@ -53,8 +54,6 @@ class ItemImageLoader : public QObject, public ItemLoaderInterface
     Q_INTERFACES(ItemLoaderInterface)
 
 public:
-    ItemImageLoader();
-
     ~ItemImageLoader();
 
     virtual ItemWidget *create(const QModelIndex &index, QWidget *parent) const;
@@ -77,7 +76,7 @@ class ItemImageLoader : public QObject, public ItemLoaderInterface
 
 private:
     QVariantMap m_settings;
-    Ui::ItemImageSettings *ui;
+    QScopedPointer<Ui::ItemImageSettings> ui;
 };
 
 #endif // ITEMIMAGE_H
diff --git a/plugins/itemnotes/itemnotes.cpp b/plugins/itemnotes/itemnotes.cpp
@@ -273,14 +273,8 @@ void ItemNotes::showToolTip()
     QToolTip::showText(toolTipPosition, m_toolTipText, this);
 }
 
-ItemNotesLoader::ItemNotesLoader()
-    : ui(NULL)
-{
-}
-
 ItemNotesLoader::~ItemNotesLoader()
 {
-    delete ui;
 }
 
 QStringList ItemNotesLoader::formatsToSave() const
@@ -298,8 +292,7 @@ QVariantMap ItemNotesLoader::applySettings()
 
 QWidget *ItemNotesLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemNotesSettings;
+    ui.reset(new Ui::ItemNotesSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
 
diff --git a/plugins/itemnotes/itemnotes.h b/plugins/itemnotes/itemnotes.h
@@ -87,8 +87,6 @@ class ItemNotesLoader : public QObject, public ItemLoaderInterface
     Q_INTERFACES(ItemLoaderInterface)
 
 public:
-    ItemNotesLoader();
-
     ~ItemNotesLoader();
 
     virtual QString id() const { return "itemnotes"; }
@@ -111,7 +109,7 @@ class ItemNotesLoader : public QObject, public ItemLoaderInterface
 
 private:
     QVariantMap m_settings;
-    Ui::ItemNotesSettings *ui;
+    QScopedPointer<Ui::ItemNotesSettings> ui;
 };
 
 #endif // ITEMNOTES_H
diff --git a/plugins/itemsync/itemsync.cpp b/plugins/itemsync/itemsync.cpp
@@ -1250,20 +1250,12 @@ private slots:
     QMap<QPersistentModelIndex, IndexData> m_indexData;
 };
 
-ItemSyncLoader::ItemSyncLoader()
-    : ui(NULL)
-    , m_settings()
-{
-}
-
 ItemSyncLoader::~ItemSyncLoader()
 {
 }
 
 QVariantMap ItemSyncLoader::applySettings()
 {
-    Q_ASSERT(ui);
-
     // Apply settings from tab sync path table.
     QTableWidget *t = ui->tableWidgetSyncTabs;
     QStringList tabPaths;
@@ -1341,8 +1333,7 @@ void setNormalStretchFixedColumns(QTableWidget *table, int normalColumn, int str
 
 QWidget *ItemSyncLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemSyncSettings;
+    ui.reset(new Ui::ItemSyncSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
 
diff --git a/plugins/itemsync/itemsync.h b/plugins/itemsync/itemsync.h
@@ -23,6 +23,7 @@
 #include "gui/icons.h"
 #include "item/itemwidget.h"
 
+#include <QScopedPointer>
 #include <QWidget>
 
 namespace Ui {
@@ -100,8 +101,6 @@ class ItemSyncLoader : public QObject, public ItemLoaderInterface
     Q_INTERFACES(ItemLoaderInterface)
 
 public:
-    ItemSyncLoader();
-
     ~ItemSyncLoader();
 
     virtual QString id() const { return "itemsync"; }
@@ -152,7 +151,7 @@ private slots:
 
     bool loadItems(QAbstractItemModel *model, const QStringList &files);
 
-    Ui::ItemSyncSettings *ui;
+    QScopedPointer<Ui::ItemSyncSettings> ui;
     QVariantMap m_settings;
     QMap<const QObject*, FileWatcher*> m_watchers;
     QMap<QString, QString> m_tabPaths;
diff --git a/plugins/itemtext/itemtext.cpp b/plugins/itemtext/itemtext.cpp
@@ -188,14 +188,8 @@ void ItemText::onSelectionChanged()
     m_copyOnMouseUp = true;
 }
 
-ItemTextLoader::ItemTextLoader()
-    : ui(NULL)
-{
-}
-
 ItemTextLoader::~ItemTextLoader()
 {
-    delete ui;
 }
 
 ItemWidget *ItemTextLoader::create(const QModelIndex &index, QWidget *parent) const
@@ -221,7 +215,6 @@ QStringList ItemTextLoader::formatsToSave() const
 
 QVariantMap ItemTextLoader::applySettings()
 {
-    Q_ASSERT(ui != NULL);
     m_settings[optionUseRichText] = ui->checkBoxUseRichText->isChecked();
     m_settings[optionMaximumLines] = ui->spinBoxMaxLines->value();
     m_settings[optionMaximumHeight] = ui->spinBoxMaxHeight->value();
@@ -230,8 +223,7 @@ QVariantMap ItemTextLoader::applySettings()
 
 QWidget *ItemTextLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemTextSettings;
+    ui.reset(new Ui::ItemTextSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
     ui->checkBoxUseRichText->setChecked( m_settings.value(optionUseRichText, true).toBool() );
diff --git a/plugins/itemtext/itemtext.h b/plugins/itemtext/itemtext.h
@@ -23,6 +23,7 @@
 #include "gui/icons.h"
 #include "item/itemwidget.h"
 
+#include <QScopedPointer>
 #include <QTextDocument>
 #include <QTextEdit>
 
@@ -63,8 +64,6 @@ class ItemTextLoader : public QObject, public ItemLoaderInterface
     Q_INTERFACES(ItemLoaderInterface)
 
 public:
-    ItemTextLoader();
-
     ~ItemTextLoader();
 
     virtual ItemWidget *create(const QModelIndex &index, QWidget *parent) const;
@@ -85,7 +84,7 @@ class ItemTextLoader : public QObject, public ItemLoaderInterface
 
 private:
     QVariantMap m_settings;
-    Ui::ItemTextSettings *ui;
+    QScopedPointer<Ui::ItemTextSettings> ui;
 };
 
 #endif // ITEMTEXT_H
diff --git a/plugins/itemweb/itemweb.cpp b/plugins/itemweb/itemweb.cpp
@@ -162,8 +162,7 @@ void ItemWeb::mouseReleaseEvent(QMouseEvent *e)
     }
 }
 
-ItemWebLoader::ItemWebLoader()
-    : ui(NULL)
+ItemWebLoader::~ItemWebLoader()
 {
 }
 
@@ -189,8 +188,7 @@ QVariantMap ItemWebLoader::applySettings()
 
 QWidget *ItemWebLoader::createSettingsWidget(QWidget *parent)
 {
-    delete ui;
-    ui = new Ui::ItemWebSettings;
+    ui.reset(new Ui::ItemWebSettings);
     QWidget *w = new QWidget(parent);
     ui->setupUi(w);
     ui->spinBoxMaxHeight->setValue( m_settings.value(optionMaximumHeight, 0).toInt() );
diff --git a/plugins/itemweb/itemweb.h b/plugins/itemweb/itemweb.h
diff --git a/utils/sanitize.sh b/utils/sanitize.sh

Original file line number	Diff line number	Diff line change
`@@ -151,14 +151,8 @@ void ItemData::contextMenuEvent(QContextMenuEvent *e)`
`151`	`151`	`e->ignore();`
`152`	`152`	`}`
`153`	`153`
`154`		`-ItemDataLoader::ItemDataLoader()`
`155`		`- : ui(NULL)`
`156`		`-{`
`157`		`-}`
`158`		`-`
`159`	`154`	`ItemDataLoader::~ItemDataLoader()`
`160`	`155`	`{`
`161`		`- delete ui;`
`162`	`156`	`}`
`163`	`157`
`164`	`158`	`ItemWidget ItemDataLoader::create(const QModelIndex &index, QWidget parent) const`
`@@ -187,8 +181,7 @@ QVariantMap ItemDataLoader::applySettings()`
`187`	`181`
`188`	`182`	`QWidget ItemDataLoader::createSettingsWidget(QWidget parent)`
`189`	`183`	`{`
`190`		`- delete ui;`
`191`		`- ui = new Ui::ItemDataSettings;`
	`184`	`+ ui.reset(new Ui::ItemDataSettings);`
`192`	`185`	`QWidget *w = new QWidget(parent);`
`193`	`186`	`ui->setupUi(w);`
`194`	`187`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ void ItemEncrypted::setModelData(QWidget editor, QAbstractItemModel model,`
`117`	`117`	`}`
`118`	`118`
`119`	`119`	`ItemEncryptedLoader::ItemEncryptedLoader()`
`120`		`- : ui(NULL)`
	`120`	`+ : ui()`
`121`	`121`	`, m_settings()`
`122`	`122`	`, m_gpgProcessStatus(GpgNotRunning)`
`123`	`123`	`, m_gpgProcess(NULL)`
`@@ -127,7 +127,6 @@ ItemEncryptedLoader::ItemEncryptedLoader()`
`127`	`127`	`ItemEncryptedLoader::~ItemEncryptedLoader()`
`128`	`128`	`{`
`129`	`129`	`terminateGpgProcess();`
`130`		`- delete ui;`
`131`	`130`	`}`
`132`	`131`
`133`	`132`	`ItemWidget ItemEncryptedLoader::create(const QModelIndex &index, QWidget parent) const`
`@@ -150,8 +149,7 @@ QVariantMap ItemEncryptedLoader::applySettings()`
`150`	`149`
`151`	`150`	`QWidget ItemEncryptedLoader::createSettingsWidget(QWidget parent)`
`152`	`151`	`{`
`153`		`- delete ui;`
`154`		`- ui = new Ui::ItemEncryptedSettings;`
	`152`	`+ ui.reset(new Ui::ItemEncryptedSettings);`
`155`	`153`	`QWidget *w = new QWidget(parent);`
`156`	`154`	`ui->setupUi(w);`
`157`	`155`
Original file line number	Diff line number	Diff line change
`@@ -531,14 +531,8 @@ QObject ItemFakeVim::createExternalEditor(const QModelIndex &index, QWidget pa`
`531`	`531`	`return m_childItem->createExternalEditor(index, parent);`
`532`	`532`	`}`
`533`	`533`
`534`		`-ItemFakeVimLoader::ItemFakeVimLoader()`
`535`		`- : ui(NULL)`
`536`		`-{`
`537`		`-}`
`538`		`-`
`539`	`534`	`ItemFakeVimLoader::~ItemFakeVimLoader()`
`540`	`535`	`{`
`541`		`- delete ui;`
`542`	`536`	`}`
`543`	`537`
`544`	`538`	`QVariant ItemFakeVimLoader::icon() const`
`@@ -563,8 +557,7 @@ void ItemFakeVimLoader::loadSettings(const QVariantMap &settings)`
`563`	`557`
`564`	`558`	`QWidget ItemFakeVimLoader::createSettingsWidget(QWidget parent)`
`565`	`559`	`{`
`566`		`- delete ui;`
`567`		`- ui = new Ui::ItemFakeVimSettings;`
	`560`	`+ ui.reset(new Ui::ItemFakeVimSettings);`
`568`	`561`	`QWidget *w = new QWidget(parent);`
`569`	`562`	`ui->setupUi(w);`
`570`	`563`
Original file line number	Diff line number	Diff line change
`@@ -99,14 +99,8 @@ QObject ItemImage::createExternalEditor(const QModelIndex &index, QWidget pare`
`99`	`99`	`return cmd.isEmpty() ? NULL : new ItemEditor(data, mime, cmd, parent);`
`100`	`100`	`}`
`101`	`101`
`102`		`-ItemImageLoader::ItemImageLoader()`
`103`		`- : ui(NULL)`
`104`		`-{`
`105`		`-}`
`106`		`-`
`107`	`102`	`ItemImageLoader::~ItemImageLoader()`
`108`	`103`	`{`
`109`		`- delete ui;`
`110`	`104`	`}`
`111`	`105`
`112`	`106`	`ItemWidget ItemImageLoader::create(const QModelIndex &index, QWidget parent) const`
`@@ -137,7 +131,6 @@ QStringList ItemImageLoader::formatsToSave() const`
`137`	`131`
`138`	`132`	`QVariantMap ItemImageLoader::applySettings()`
`139`	`133`	`{`
`140`		`- Q_ASSERT(ui != NULL);`
`141`	`134`	`m_settings["max_image_width"] = ui->spinBoxImageWidth->value();`
`142`	`135`	`m_settings["max_image_height"] = ui->spinBoxImageHeight->value();`
`143`	`136`	`m_settings["image_editor"] = ui->lineEditImageEditor->text();`
`@@ -147,8 +140,7 @@ QVariantMap ItemImageLoader::applySettings()`
`147`	`140`
`148`	`141`	`QWidget ItemImageLoader::createSettingsWidget(QWidget parent)`
`149`	`142`	`{`
`150`		`- delete ui;`
`151`		`- ui = new Ui::ItemImageSettings;`
	`143`	`+ ui.reset(new Ui::ItemImageSettings);`
`152`	`144`	`QWidget *w = new QWidget(parent);`
`153`	`145`	`ui->setupUi(w);`
`154`	`146`	`ui->spinBoxImageWidth->setValue( m_settings.value("max_image_width", 320).toInt() );`
Original file line number	Diff line number	Diff line change
`@@ -273,14 +273,8 @@ void ItemNotes::showToolTip()`
`273`	`273`	`QToolTip::showText(toolTipPosition, m_toolTipText, this);`
`274`	`274`	`}`
`275`	`275`
`276`		`-ItemNotesLoader::ItemNotesLoader()`
`277`		`- : ui(NULL)`
`278`		`-{`
`279`		`-}`
`280`		`-`
`281`	`276`	`ItemNotesLoader::~ItemNotesLoader()`
`282`	`277`	`{`
`283`		`- delete ui;`
`284`	`278`	`}`
`285`	`279`
`286`	`280`	`QStringList ItemNotesLoader::formatsToSave() const`
`@@ -298,8 +292,7 @@ QVariantMap ItemNotesLoader::applySettings()`
`298`	`292`
`299`	`293`	`QWidget ItemNotesLoader::createSettingsWidget(QWidget parent)`
`300`	`294`	`{`
`301`		`- delete ui;`
`302`		`- ui = new Ui::ItemNotesSettings;`
	`295`	`+ ui.reset(new Ui::ItemNotesSettings);`
`303`	`296`	`QWidget *w = new QWidget(parent);`
`304`	`297`	`ui->setupUi(w);`
`305`	`298`
Original file line number	Diff line number	Diff line change
`@@ -188,14 +188,8 @@ void ItemText::onSelectionChanged()`
`188`	`188`	`m_copyOnMouseUp = true;`
`189`	`189`	`}`
`190`	`190`
`191`		`-ItemTextLoader::ItemTextLoader()`
`192`		`- : ui(NULL)`
`193`		`-{`
`194`		`-}`
`195`		`-`
`196`	`191`	`ItemTextLoader::~ItemTextLoader()`
`197`	`192`	`{`
`198`		`- delete ui;`
`199`	`193`	`}`
`200`	`194`
`201`	`195`	`ItemWidget ItemTextLoader::create(const QModelIndex &index, QWidget parent) const`
`@@ -221,7 +215,6 @@ QStringList ItemTextLoader::formatsToSave() const`
`221`	`215`
`222`	`216`	`QVariantMap ItemTextLoader::applySettings()`
`223`	`217`	`{`
`224`		`- Q_ASSERT(ui != NULL);`
`225`	`218`	`m_settings[optionUseRichText] = ui->checkBoxUseRichText->isChecked();`
`226`	`219`	`m_settings[optionMaximumLines] = ui->spinBoxMaxLines->value();`
`227`	`220`	`m_settings[optionMaximumHeight] = ui->spinBoxMaxHeight->value();`
`@@ -230,8 +223,7 @@ QVariantMap ItemTextLoader::applySettings()`
`230`	`223`
`231`	`224`	`QWidget ItemTextLoader::createSettingsWidget(QWidget parent)`
`232`	`225`	`{`
`233`		`- delete ui;`
`234`		`- ui = new Ui::ItemTextSettings;`
	`226`	`+ ui.reset(new Ui::ItemTextSettings);`
`235`	`227`	`QWidget *w = new QWidget(parent);`
`236`	`228`	`ui->setupUi(w);`
`237`	`229`	`ui->checkBoxUseRichText->setChecked( m_settings.value(optionUseRichText, true).toBool() );`
Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,7 @@ void ItemWeb::mouseReleaseEvent(QMouseEvent *e)`
`162`	`162`	`}`
`163`	`163`	`}`
`164`	`164`
`165`		`-ItemWebLoader::ItemWebLoader()`
`166`		`- : ui(NULL)`
	`165`	`+ItemWebLoader::~ItemWebLoader()`
`167`	`166`	`{`
`168`	`167`	`}`
`169`	`168`
`@@ -189,8 +188,7 @@ QVariantMap ItemWebLoader::applySettings()`
`189`	`188`
`190`	`189`	`QWidget ItemWebLoader::createSettingsWidget(QWidget parent)`
`191`	`190`	`{`
`192`		`- delete ui;`
`193`		`- ui = new Ui::ItemWebSettings;`
	`191`	`+ ui.reset(new Ui::ItemWebSettings);`
`194`	`192`	`QWidget *w = new QWidget(parent);`
`195`	`193`	`ui->setupUi(w);`
`196`	`194`	`ui->spinBoxMaxHeight->setValue( m_settings.value(optionMaximumHeight, 0).toInt() );`