Reponsive features and fixes #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the homepage for example, stack the image and the message when any becomes smaller than 50rem. Remaining issue: since the image and message are alternated, in some cases the image stacks below the message
Add a @media query to change featured items flex direction from row (default) to column on screens narrower than 800px
Remove the flex wrap properties and use instead a media query. This makes it consistent with the featured items, and allows for a fix of the image/message order issue. On smaller screens (under 800px) the image will always display above the message.
…eens" This reverts commit 4c87ed8f647b041648cb854453653499c14acfaa.
This reverts commit e647ef9bd7d29a3650e44c914e1f639b57a3a8fd.
- Change header layout to include both navs into one (also good for accessibility) - Don't let logo scroll - The nav scrolls when overflowing - Fix styles to apply to nav instead of header
The scroll bar can not be hidden in Firefox (Gecko) using CSS as of 2018 See: https://stackoverflow.com/a/6165489/7770081 Possible solutions: https://stackoverflow.com/a/16671476/7770081
|
About typography: reducing the font size overall, as we talked about, fixed it. I don't think we need to reduce it further on mobile. |
|
You can merge @bogreudell! I'll work on specific fixes in separate PRs |
|
Commit 14970e4 fixes issue #38, apart from a tiny bug on textareas: The textarea's width is misbehaving because of a hardcoded HTML @bogreudell is there a way to disable this in the Wordpress form? I'll style the textarea with CSS only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7:
Fixes #38