#232: 온보딩 바텀시트 작업 + 서버 드리븐 베이스 작업 추가 #233
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongjaino
reviewed
Feb 2, 2025
Comment on lines
53
to
55
| module-graph = "2.7.1" | ||
| material = "1.10.0" | ||
|
|
There was a problem hiding this comment.
정승원이 죽인 material을 브라우니가 다시 추가한다라,,,,
jeongjaino
reviewed
Feb 2, 2025
Comment on lines
+72
to
+92
| items(contents) { content -> | ||
| when (content) { | ||
| is TitleComponent -> { | ||
| TitleSection(title = content.text) | ||
| } | ||
|
|
||
| is TextListComponent -> { | ||
| TextListSection(textList = content.textList) | ||
| } | ||
|
|
||
| is ImageComponent -> { | ||
| ImageSection( | ||
| imageUrl = content.url, | ||
| width = content.width, | ||
| height = content.height, | ||
| ) | ||
| } | ||
|
|
||
| is ButtonComponent -> { | ||
| ButtonSection(text = content.text, onClick = onClick) | ||
| } |
There was a problem hiding this comment.
크 ,,,
도메인 단에서 미리 정해주는 게 아니라, UI 단에서 이렇게 하는 군요
이렇게 해야 순서가 변경되어도 대응을 할 수 있는거고요 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 📄 관련된 이슈 및 소개
close #232
2. 🔥 변경된 점
3. ✅ 필수 체크 사항
4. 📸 작업물 사진 공유(선택)
2025-02-01.8.26.01.mov
5. 💡알게된 혹은 궁금한 사항