Skip to content

Commit f34ea5f

Browse files
authored
HIVE-23938: LLAP: JDK11 - some GC log file rotation related jvm arguments cannot be used anymore (apache#1430) (Laszlo Bodor reviewed by Ashutosh Chauhan)
1 parent 48a152d commit f34ea5f

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

llap-server/bin/runLlapDaemon.sh

+6-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,12 @@ shift
5252
JAVA=$JAVA_HOME/bin/java
5353
LOG_LEVEL_DEFAULT="INFO"
5454
LOGGER_DEFAULT="console"
55-
JAVA_OPTS_BASE="-server -Djava.net.preferIPv4Stack=true -XX:+UseNUMA -XX:+PrintGCDetails -verbose:gc -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=4 -XX:GCLogFileSize=100M -XX:+PrintGCDateStamps"
55+
JAVA_VERSION=$($JAVA -version 2>&1 | grep -i version | cut -d'"' -f2 | cut -d'.' -f1) # returns "1", "9", "11" for jdk 8,9,11 respectively
56+
JAVA_GC_OPTS="-XX:+PrintGCDetails -XX:+UseGCLogFileRotation -XX:NumberOfGCLogFiles=4 -XX:GCLogFileSize=100M -XX:+PrintGCDateStamps"
57+
if [ "$JAVA_VERSION" -gt "1" ]; then # from java9+, -Xlog argument should be used
58+
JAVA_GC_OPTS="-Xlog:gc*,safepoint:gc.log:time,uptime:filecount=4,filesize=100M"
59+
fi
60+
JAVA_OPTS_BASE="-server -Djava.net.preferIPv4Stack=true -XX:+UseNUMA -verbose:gc $JAVA_GC_OPTS"
5661

5762
if [ ! -d "${LLAP_DAEMON_HOME}" ]; then
5863
echo No LLAP_DAEMON_HOME set, or is not a directory.

0 commit comments

Comments
 (0)