-
Notifications
You must be signed in to change notification settings - Fork 126
AVAudioEngine version AudioDeviceModule 2 #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hiroshihorie
wants to merge
82
commits into
m125_release
Choose a base branch
from
hiroshi/livekit-m125-adm-audioengine
base: m125_release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 98dc0ac Author: Hiroshi Horie <[email protected]> Date: Thu Jan 23 03:27:20 2025 +0900 Rendering fix commit 345f8b7 Author: Hiroshi Horie <[email protected]> Date: Thu Jan 23 00:41:35 2025 +0900 Manual rendering commit be003d5 Author: Hiroshi Horie <[email protected]> Date: Wed Jan 22 12:03:18 2025 +0900 RTCAudioDeviceModuleDelegate commit 2babb14 Author: Hiroshi Horie <[email protected]> Date: Fri Jan 17 16:18:39 2025 +0900 Squashed recent improvements Pre initialize mode Pre initialize logic Persistent Checks Fix buffer logic Patch default input_mute state Buffer checks Start buffer on enable Delay estimate 0 Stop engine on interrupt Pass should_resume Silence warning Correct session config Fix state Start logic Misc Rem ses Rem ses2 State helper Minor patch Simplify Change stop create order Working state Ref State helpers commit 235da97 Author: Hiroshi Horie <[email protected]> Date: Tue Jan 14 15:52:32 2025 +0900 Squashed recent progress commit 6ba820c Author: Hiroshi Horie <[email protected]> Date: Tue Dec 31 01:57:09 2024 +0900 Squashed recent progress Fix adm selection Fixes Revert adm selection in audio_device_impl Rename IsManualRenderingMode Simplify pcm buffer delegate Fixes Fixes Ducking config Strip manual rendering logic Runtime-ducking config Fix compile Fix start recording Connect output Buffer logic Enable output when input is enabled commit 49ca1ee Author: Hiroshi Horie <[email protected]> Date: Sun Dec 22 04:32:07 2024 +0700 Check AGC commit 5bbeb48 Author: Hiroshi Horie <[email protected]> Date: Sat Dec 21 14:15:31 2024 +0700 Debug print audio graph commit 631126f Author: Hiroshi Horie <[email protected]> Date: Fri Dec 20 23:24:42 2024 +0700 Fix macOS vp commit e07b814 Author: Hiroshi Horie <[email protected]> Date: Tue Dec 17 12:28:55 2024 +0700 Clean up imports commit 1bdb158 Author: Hiroshi Horie <[email protected]> Date: Wed Dec 11 12:35:12 2024 +0700 Muted talker detection commit 0324b22 Author: Hiroshi Horie <[email protected]> Date: Mon Dec 16 21:11:45 2024 +0700 Rename AudioDeviceSink commit ed22ffb Author: Hiroshi Horie <[email protected]> Date: Tue Dec 17 01:11:23 2024 +0700 Move to private method commit db00fe4 Author: Hiroshi Horie <[email protected]> Date: Wed Dec 11 00:16:55 2024 +0700 Other audio ducking commit a7282bd Author: Hiroshi Horie <[email protected]> Date: Thu Dec 5 15:27:34 2024 +0700 AudioEngine commit d31187b Author: Hiroshi Horie <[email protected]> Date: Thu Dec 5 15:26:38 2024 +0700 Connect voice engine mute to adm commit 3df68d4 Author: Hiroshi Horie <[email protected]> Date: Fri Oct 11 20:41:44 2024 +0900 Revert "Stop recording on mute (turn off mic indicator) (#55)" This reverts commit c0209ef.
AudioOptions initially false
…to hiroshi/livekit-m125-adm-audioengine
This reverts commit 821c91a.
Format Log device name Default patch 1 Engine start bug workaround Change sleep time Restart engine only if stopped Patch Default device update count Recreate on device change
cloudwebrtc
approved these changes
Jul 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #158