fix(generate_licenses): add missing licenses for ffmpeg and openh264 #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see there's a patch in the webrtc-build repo adding licenses, this should probably go there instead? |
cloudwebrtc
approved these changes
Jul 1, 2025
|
Anything else I need to do to allow this to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a custom build with the following command line fails the build during the license generation step because these components were added to the build without their licenses being declared here.
python tools_webrtc/ios/build_ios_libs.py --build_config release --arch arm64 x64 --extra-gn-args ios_enable_code_signing=false is_component_build=false rtc_include_tests=false is_debug=false enable_dsyms=false rtc_libvpx_build_vp9=true use_goma=false rtc_enable_symbol_export=true rtc_build_examples=false rtc_use_h264=true use_rtti=true use_custom_libcxx=false