Skip to content

Commit 7f533c8

Browse files
N0taN3rdikreymer
authored andcommitted
removed the mutable default value for warc_header_dict keyword arg in BaseWARCWriter:create_revisit_record and BaseWARCWriter:create_warc_record (#70)
1 parent 759ab07 commit 7f533c8

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

warcio/warcwriter.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,11 @@ def create_warcinfo_record(self, filename, info):
167167
length=length)
168168

169169
def create_revisit_record(self, uri, digest, refers_to_uri, refers_to_date,
170-
http_headers=None, warc_headers_dict={}):
170+
http_headers=None, warc_headers_dict=None):
171171

172172
assert digest, 'Digest can not be empty'
173+
if warc_headers_dict is None:
174+
warc_headers_dict = dict()
173175

174176
record = self.create_warc_record(uri, 'revisit', http_headers=http_headers,
175177
warc_headers_dict=warc_headers_dict)
@@ -187,9 +189,11 @@ def create_warc_record(self, uri, record_type,
187189
payload=None,
188190
length=None,
189191
warc_content_type='',
190-
warc_headers_dict={},
192+
warc_headers_dict=None,
191193
warc_headers=None,
192194
http_headers=None):
195+
if warc_headers_dict is None:
196+
warc_headers_dict = dict()
193197

194198
if payload and not http_headers:
195199
loader = ArcWarcRecordLoader()

0 commit comments

Comments
 (0)