Skip to content

Commit 05f5205

Browse files
GeorgegriffggriffithsIDBS
authored andcommitted
Return null when not found
1 parent 5c727b0 commit 05f5205

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "query-selector-shadow-dom",
3-
"version": "0.3.1",
3+
"version": "0.3.2",
44
"description": "use querySelector syntax to search for nodes inside of (nested) shadow roots",
55
"main": "src/querySelectorDeep.js",
66
"scripts": {

src/querySelectorDeep.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ function _querySelectorDeep(selector, findMany, root) {
5757
return acc;
5858
} else {
5959
acc = possibleElements.find(findElements);
60-
return acc;
60+
return acc || null;
6161
}
6262
}, findMany ? [] : null);
6363

test/basic.spec.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,20 @@ describe("Basic Suite", function() {
3030
});
3131

3232
it("exports querySelectorDeep function", function() {
33-
expect(querySelectorAllDeep).toEqual(jasmine.any(Function));
33+
expect(querySelectorDeep).toEqual(jasmine.any(Function));
34+
});
35+
36+
it("querySelectorDeep returns null when not found", function() {
37+
expect(querySelectorDeep('whatever')).toBeNull();
3438
});
3539

40+
it("querySelectorAllDeep returns empty array when not found", function() {
41+
const foundElements = querySelectorAllDeep('whatever');
42+
expect(foundElements).toEqual(jasmine.any(Array));
43+
expect(foundElements.length).toEqual(0);
44+
});
45+
46+
3647
describe("querySelectorDeep", function() {
3748
it('can access an element in the light dom', function() {
3849
createTestComponent(parent);

0 commit comments

Comments
 (0)