Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Dimension Label Naming Convention Causing Mismatch #107

Open
LarryLovestein opened this issue Dec 10, 2024 · 1 comment
Open

Comments

@LarryLovestein
Copy link

Hello,

I have encountered an issue with the way new label dimensions are created in the azure-metrics-exporter. The current implementation uses the following code:
labelName := "dimension" + stringsCommon.UppercaseFirst(dimensionName)
This approach capitalizes the first letter of the dimension name, which leads to inconsistencies with other labels.

A better approach would be to use the following format:
labelName := "dimension_" + dimensionName

This would ensure consistency across all labels. Additionally, using this format allows for label mapping, enabling us to retain the original name of the label.

@LarryLovestein
Copy link
Author

@mblaschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant