[TASK] Refactor JavaScript implementation

The issue on TYPO3 13 having the button label writing outside the
borders made a refactoring and regeneration of the localization.ts
necessary.

The labels were rewritten as CDATA to allow line breaks, getting rid of
the too long labels.

Together with TYPO3 Core standardized TSconfig for localizations the
overridden JavaScript is more lightweight and doesn't need the AjaxRoute
anymore.

Therefore the AjaxRoutes.php and AjaxController.php are removed.

In addition to Core functionality, the DeepL allow translateion now can
be enabled/disabled by the following setting in Page TSConfig:

```
# Enabled (Default)
mod.web_layout.localization.enableDeeplTranslate = 1
# Disabled
mod.web_layout.localization.enableDeeplTranslate = 0
```

This could be overridden in User TSconfig, too:
```
# Enabled (Default)
page.mod.web_layout.localization.enableDeeplTranslate = 1
# Disabled
page.mod.web_layout.localization.enableDeeplTranslate = 0
```

Author: calien666

Classes/Configuration.php

@@ -4,6 +4,7 @@
 
 namespace WebVision\Deepltranslate\Core;
 
+use TYPO3\CMS\Backend\Utility\BackendUtility;
 use Symfony\Component\DependencyInjection\Attribute\AsAlias;
 use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationExtensionNotConfiguredException;
 use TYPO3\CMS\Core\Configuration\Exception\ExtensionConfigurationPathDoesNotExistException;
@@ -30,4 +31,20 @@ public function getApiKey(): string
     {
         return $this->apiKey;
     }
+
+    /**
+     * Checks translation allowed against Page TSconfig from settings
+     *
+     * @param int $pageId
+     * @return bool
+     * @throws \JsonException
+     */
+    public function isDeeplTranslationAllowedOnPage(int $pageId): bool
+    {
+        $localizationConfiguration = BackendUtility::getPagesTSconfig($pageId)['mod.']['web_layout.']['localization.'] ?? [];
+        if ((bool)($localizationConfiguration['enableDeeplTranslate'] ?? true) === false) {
+            return false;
+        }
+        return true;
+    }
 }

Classes/ConfigurationInterface.php

@@ -13,4 +13,6 @@
 interface ConfigurationInterface
 {
     public function getApiKey(): string;
+
+    public function isDeeplTranslationAllowedOnPage(int $pageId): bool;
 }

Classes/Controller/Backend/AjaxController.php

@@ -7,20 +7,26 @@
 use Psr\EventDispatcher\EventDispatcherInterface;
 use TYPO3\CMS\Backend\Controller\Event\RenderAdditionalContentToRecordListEvent;
 use TYPO3\CMS\Core\Site\Entity\Site;
+use WebVision\Deepltranslate\Core\ConfigurationInterface;
 use WebVision\Deepltranslate\Core\Event\RenderLocalizationSelectAllowed;
 use WebVision\Deepltranslate\Core\Form\TranslationDropdownGenerator;
 
 final class RenderLocalizationSelect
 {
     public function __construct(
         private readonly TranslationDropdownGenerator $generator,
-        private readonly EventDispatcherInterface $eventDispatcher
+        private readonly EventDispatcherInterface $eventDispatcher,
+        private readonly ConfigurationInterface $configuration
     ) {
     }
 
     public function __invoke(RenderAdditionalContentToRecordListEvent $event): void
     {
         $request = $event->getRequest();
+        $currentPageId = (int)($request->getQueryParams()['id'] ?? 0);
+        if (!$this->configuration->isDeeplTranslationAllowedOnPage($currentPageId)) {
+            return;
+        }
         // Check, if some event listener doesn't allow rendering here.
         // For use cases see Event
         $renderingAllowedEvent = $this->eventDispatcher->dispatch(new RenderLocalizationSelectAllowed($request));

Classes/Event/Listener/RenderLocalizationSelect.php

@@ -5,19 +5,31 @@
 namespace WebVision\Deepltranslate\Core\ViewHelpers\Be\Access;
 
 use TYPO3\CMS\Core\Authentication\BackendUserAuthentication;
+use TYPO3\CMS\Core\Utility\GeneralUtility;
+use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
 use TYPO3Fluid\Fluid\Core\Rendering\RenderingContextInterface;
 use TYPO3Fluid\Fluid\Core\ViewHelper\AbstractConditionViewHelper;
 use WebVision\Deepltranslate\Core\Access\AllowedTranslateAccess;
+use WebVision\Deepltranslate\Core\ConfigurationInterface;
 
+/**
+ * @internal This ViewHelper is marked internal and only to be used within
+ * the DeepL translate packages and therefore no public API.
+ */
 final class DeeplTranslateAllowedViewHelper extends AbstractConditionViewHelper
 {
-    public function initializeArguments(): void
-    {
-        parent::initializeArguments();
-    }
-
     public static function verdict(array $arguments, RenderingContextInterface $renderingContext): bool
     {
+        $deeplConfiguration = GeneralUtility::makeInstance(ConfigurationInterface::class);
+        if ($deeplConfiguration->getApiKey() === '') {
+            return false;
+        }
+        /** @var RenderingContext $renderingContext */
+        $currentPageId = (int)($renderingContext->getRequest()?->getQueryParams()['id'] ?? 0);
+        // set default to true avoiding breaking behaviour issues
+        if (!$deeplConfiguration->isDeeplTranslationAllowedOnPage($currentPageId)) {
+            return false;
+        }
         if (self::getBackendUserAuthentication()->check('custom_options', AllowedTranslateAccess::ALLOWED_TRANSLATE_OPTION_VALUE)) {
             return true;
         }

Classes/ViewHelpers/Be/Access/DeeplTranslateAllowedViewHelper.php

@@ -12,16 +12,16 @@
 				<target>Mit DeepL übersetzen</target>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateHeader">
-				<source>Translate with DeepL</source>
-				<target>Mit DeepL übersetzen</target>
+				<source>DeepL Translate</source>
+				<target>DeepL Übersetzung</target>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateHeaderAutodetect">
-				<source>Translate with DeepL (autodetect)</source>
-				<target>Mit DeepL übersetzen (autodetect)</target>
+				<source><![CDATA[DeepL Translate<br>(autodetect)]]></source>
+				<target><![CDATA[DeepL Übersetzung<br>(autodetect)]]></target>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslate" xml:space="preserve">
-				<source><![CDATA[Translating content using DeepL Translate will create a translation from the source language to the language translation you selected. The translated content will be fetched from DeepL translation service (DeepL claims 99 percentage accuracy). The DeepL service supports translation to and from English, French, German, Spanish, Italian, Dutch, and Polish languages. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
-				<target><![CDATA[Wenn Sie Inhalte mit DeepL Translate übersetzen, wird eine Übersetzung von der Ausgangssprache in die von Ihnen ausgewählte Sprache erstellt. Der übersetzte Inhalt wird vom DeepL Übersetzungsdienst abgerufen (DeepL behauptet eine 99-prozentige Genauigkeit). Der Dienst DeepL unterstützt die Übersetzung in und aus den Sprachen Englisch, Französisch, Deutsch, Spanisch, Italienisch, Niederländisch und Polnisch. Andere Sprachen werden ignoriert und die normale Übersetzungsfunktion von TYPO3 wird verwendet.]]></target>
+				<source><![CDATA[Translating content via DeepL translate will create a translation from source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from <a href="https://developers.deepl.com/docs/getting-started/supported-languages" target="_blank">different languages</a>. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
+				<target><![CDATA[Die Übersetzung von Inhalten über DeepL translate erstellt eine Übersetzung von der Ausgangssprache in die Sprache, in die Sie übersetzen. Der übersetzte Inhalt wird vom DeepL Übersetzungsdienst stammen, der zu 99% genau ist. Der Dienst DeepL unterstützt die Übersetzung in und aus <a href="https://developers.deepl.com/docs/getting-started/supported-languages" target="_blank">verschiedenen Sprachen</a>. Andere Sprachen werden ignoriert und es wird die normale Übersetzungsfunktion von TYPO3 verwendet.]]></target>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateAuto" xml:space="preserve">
 				<source><![CDATA[Translating content using DeepL Translate (autodetect) will create a translation from the auto detected source language to the language translation you selected. The translated content will be fetched from DeepL translation service (DeepL claims 99 percentage accuracy). The DeepL service supports translation to and from English, French, German, Spanish, Italian, Dutch, and Polish languages. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>

Configuration/Backend/AjaxRoutes.php

@@ -4,17 +4,17 @@
 		<header/>
 		<body>
 			<trans-unit id="localize.educate.deepltranslateHeader">
-				<source>Translate with DeepL</source>
-				<target>Traduire avec DeepL</target>
+				<source>DeepL translate</source>
+				<target>DeepL traduire</target>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateHeaderAutodetect">
-				<source>Translate (DeepL) (autodetect)</source>
-				<target>Traduire (DeepL) (détection automatique)</target>
+				<source><![CDATA[DeepL Translate<br>(autodetect)]]></source>
+				<target><![CDATA[DeepL traduire<br>(auto détection)]]></target>
 			</trans-unit>
 
 			<trans-unit id="localize.educate.deepltranslate" xml:space="preserve">
-				<source><![CDATA[Translating content via DeepL translate will create a translation from source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from English, French, German, Spanish, Italian, Dutch, and Polish languages. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
-				<target><![CDATA[La traduction de contenu via DeepL translate créera une traduction de la langue source vers la langue vers laquelle vous traduisez. Le contenu traduit proviendra du service de traduction DeepL qui est précis à 99 %. Le service DeepL prend en charge la traduction vers et depuis l'anglais, le français, l'allemand, l'espagnol et l'italien. , néerlandais et polonais. Les autres langues seront ignorées et utiliseront par défaut l'opération de traduction normale de TYPO3.]]></target>
+				<source><![CDATA[Translating content via DeepL translate will create a translation from source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from <a href="https://developers.deepl.com/docs/getting-started/supported-languages" target="_blank">different languages</a>. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
+				<target><![CDATA[La traduction d'un contenu via DeepL translate créera une traduction de la langue source vers la langue vers laquelle vous traduisez. Le contenu traduit proviendra du service de traduction DeepL qui est précis à 99%. Le service DeepL prend en charge la traduction vers et depuis <a href="https://developers.deepl.com/docs/getting-started/supported-languages" target="_blank">différentes langues</a>. Les autres langues seront ignorées et la traduction normale de TYPO3 sera appliquée par défaut.]]></target>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateAuto" xml:space="preserve">
 				<source><![CDATA[Translating content via DeepL translate will create a translation from <b>auto detected</b> source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from English, French, German, Spanish, Italian, Dutch, and Polish languages. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>

Resources/Private/Language/de.locallang.xlf

@@ -10,17 +10,17 @@
 				<source>Translate with DeepL</source>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateHeader">
-				<source>Translate with DeepL</source>
+				<source>DeepL Translate</source>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateHeaderAutodetect">
-				<source>Translate with DeepL (autodetect)</source>
+				<source><![CDATA[DeepL Translate<br>(autodetect)]]></source>
 			</trans-unit>
 
 			<trans-unit id="localize.educate.deepltranslate" xml:space="preserve">
-				<source>Translating content via DeepL translate will create a translation from source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from English, French, German, Spanish, Italian, Dutch, and Polish languages. Other languages will be ignored and will default to the normal translate operation of TYPO3.</source>
+				<source><![CDATA[Translating content via DeepL translate will create a translation from source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from <a href="https://developers.deepl.com/docs/getting-started/supported-languages" target="_blank">different languages</a>. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
 			</trans-unit>
 			<trans-unit id="localize.educate.deepltranslateAuto" xml:space="preserve">
-				<source><![CDATA[Translating content via DeepL translate will create a translation from <b>auto detected</b> source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from English, French, German, Spanish, Italian, Dutch, and Polish languages. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
+				<source><![CDATA[Translating content via DeepL translate will create a translation from <b>auto detected</b> source language to the language you translate to. The translated content will be from DeepL translation service which is 99% accurate. DeepL service supports translation to and from <a href="https://developers.deepl.com/docs/getting-started/supported-languages" target="_blank">different languages</a>. Other languages will be ignored and will default to the normal translate operation of TYPO3.]]></source>
 			</trans-unit>
 
 			<trans-unit id="localize.educate.deeplSettingsFailure">