cast keyset generation console arguments to int and remove dangerous defaults (#339)

Co-authored-by: Lucas Granberg <[email protected]>

Author: lucasgranberg

src/Component/Console/EcKeysetGeneratorCommand.php

@@ -28,10 +28,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $quantity = $input->getArgument('quantity');
-        if (! is_int($quantity)) {
-            $quantity = 1;
-        }
+        $quantity = (int)$input->getArgument('quantity');
         if ($quantity < 1) {
             throw new InvalidArgumentException('Invalid quantity');
         }

src/Component/Console/OctKeyGeneratorCommand.php

@@ -25,10 +25,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $size = $input->getArgument('size');
-        if (! is_int($size)) {
-            $size = 1;
-        }
+        $size = (int)$input->getArgument('size');
         if ($size < 1) {
             throw new InvalidArgumentException('Invalid size');
         }

src/Component/Console/OctKeysetGeneratorCommand.php

@@ -27,15 +27,8 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $quantity = $input->getArgument('quantity');
-        if (! is_int($quantity)) {
-            $quantity = 1;
-        }
-
-        $size = $input->getArgument('size');
-        if (! is_int($size)) {
-            $size = 1;
-        }
+        $quantity = (int)$input->getArgument('quantity');
+        $size = (int)$input->getArgument('size');
         if ($quantity < 1) {
             throw new InvalidArgumentException('Invalid quantity');
         }

src/Component/Console/OkpKeysetGeneratorCommand.php

@@ -28,10 +28,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $quantity = $input->getArgument('quantity');
-        if (! is_int($quantity)) {
-            $quantity = 1;
-        }
+        $quantity = (int)$input->getArgument('quantity');
         $curve = $input->getArgument('curve');
         if ($quantity < 1) {
             throw new InvalidArgumentException('Invalid quantity');

src/Component/Console/RsaKeyGeneratorCommand.php

@@ -25,10 +25,7 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $size = $input->getArgument('size');
-        if (! is_int($size)) {
-            $size = 1;
-        }
+        $size = (int)$input->getArgument('size');
         $args = $this->getOptions($input);
         if ($size < 1) {
             throw new InvalidArgumentException('Invalid size');

src/Component/Console/RsaKeysetGeneratorCommand.php

@@ -27,14 +27,8 @@ protected function configure(): void
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $quantity = $input->getArgument('quantity');
-        if (! is_int($quantity)) {
-            $quantity = 1;
-        }
-        $size = $input->getArgument('size');
-        if (! is_int($size)) {
-            $size = 1;
-        }
+        $quantity = (int)$input->getArgument('quantity');
+        $size = (int)$input->getArgument('size');
         if ($quantity < 1) {
             throw new InvalidArgumentException('Invalid quantity');
         }