Skip to content

chore: remove SIGTERM event handler #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 10, 2025
Merged

chore: remove SIGTERM event handler #680

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1bd6c0c
chore: register SIGTERM event before worker terminated
9aoy Nov 7, 2025
21f56c7
Update packages/core/src/runtime/worker/index.ts
9aoy Nov 7, 2025
731556e
fix: remove SIGTERM event handler
9aoy Nov 7, 2025
77d7d23
fix: remove SIGTERM event handler
9aoy Nov 7, 2025
d8fe789
fix: skip windows
9aoy Nov 7, 2025
e07bc3d
fix: skip windows
9aoy Nov 7, 2025
50a1e4f
fix: remove debug log
9aoy Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/pool/forks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export const createForksPool = (poolOptions: {
execArgv,
maxThreads,
minThreads,
teardown: 'teardown',
concurrentTasksPerWorker: 1,
isolateWorkers: isolate,
};
Expand Down
16 changes: 8 additions & 8 deletions packages/core/src/runtime/worker/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,6 @@ const loadFiles = async ({
});
};

const onExit = () => {
process.exit();
};

const runInPool = async (
options: RunWorkerOptions['options'],
): Promise<
Expand Down Expand Up @@ -294,15 +290,11 @@ const runInPool = async (
process.exit = exit;
});

process.off('SIGTERM', onExit);

const teardown = async () => {
await new Promise((resolve) => getRealTimers().setTimeout!(resolve));

await Promise.all(cleanups.map((fn) => fn()));
isTeardown = true;
// should exit correctly when user's signal listener exists
process.once('SIGTERM', onExit);
};

if (type === 'collect') {
Expand Down Expand Up @@ -428,4 +420,12 @@ const runInPool = async (
}
};

// should be called before worker is terminated
export const teardown = (): void => {
// should exit correctly when user's signal listener exists
process.once('SIGTERM', () => {
process.exit();
});
};

export default runInPool;
Loading