From bf543eced648c643ecfda8245bbc702c79ee0ec2 Mon Sep 17 00:00:00 2001
From: yifancong <easy_cong@126.com>
Date: Tue, 3 Sep 2024 19:30:14 +0800
Subject: [PATCH] fix(sdk): saveManifest need await when brief mode (#498)

---
 .changeset/stupid-comics-mate.md      | 6 ++++++
 packages/sdk/src/sdk/sdk/webpack.ts   | 4 ++--
 packages/webpack-plugin/src/plugin.ts | 4 +++-
 3 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/stupid-comics-mate.md

diff --git a/.changeset/stupid-comics-mate.md b/.changeset/stupid-comics-mate.md
new file mode 100644
index 00000000..815a6c0e
--- /dev/null
+++ b/.changeset/stupid-comics-mate.md
@@ -0,0 +1,6 @@
+---
+'@rsdoctor/webpack-plugin': patch
+'@rsdoctor/sdk': patch
+---
+
+fix(sdk): saveManifest need await when brief mode
diff --git a/packages/sdk/src/sdk/sdk/webpack.ts b/packages/sdk/src/sdk/sdk/webpack.ts
index 1dff59aa..9ec38a4a 100644
--- a/packages/sdk/src/sdk/sdk/webpack.ts
+++ b/packages/sdk/src/sdk/sdk/webpack.ts
@@ -373,7 +373,7 @@ export class RsdoctorWebpackSDK<
     }
   }
 
-  public writeStore(options?: SDK.WriteStoreOptionsType) {
+  public async writeStore(options?: SDK.WriteStoreOptionsType) {
     debug(() => `sdk.writeStore has run.`, '[SDK.writeStore][end]');
     if (this.extraConfig?.mode === SDK.IMode[SDK.IMode.brief]) {
       const clientHtmlPath = this.extraConfig.innerClientPath
@@ -381,7 +381,7 @@ export class RsdoctorWebpackSDK<
         : require.resolve('@rsdoctor/client');
 
       if (this.extraConfig.brief?.writeDataJson) {
-        this.saveManifest(this.getStoreData(), options || {});
+        await this.saveManifest(this.getStoreData(), options || {});
       }
       return this.inlineScriptsAndStyles(clientHtmlPath);
     }
diff --git a/packages/webpack-plugin/src/plugin.ts b/packages/webpack-plugin/src/plugin.ts
index 87ff2fbf..1b6d8fad 100644
--- a/packages/webpack-plugin/src/plugin.ts
+++ b/packages/webpack-plugin/src/plugin.ts
@@ -214,6 +214,8 @@ export class RsdoctorWebpackPlugin<Rules extends Linter.ExtendRuleData[]>
         );
         openBrowser(`file:///${outputFilePath}`);
       }
-    } catch (e) {}
+    } catch (e) {
+      console.error(`[Rsdoctor] Webpack plugin this.done error`, e);
+    }
   };
 }