Skip to content

Commit 58a405a

Browse files
committed
refactor(openBrowser): delay import of open package and open on win32 platform
1 parent 9ce6d16 commit 58a405a

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

packages/sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"fs-extra": "^11.1.1",
3333
"json-cycle": "^1.5.0",
3434
"lodash": "^4.17.21",
35-
"open": "^8.4.2",
35+
"open": "^10.1.2",
3636
"sirv": "2.0.4",
3737
"socket.io": "4.8.1",
3838
"source-map": "^0.7.4",

packages/sdk/src/sdk/utils/openBrowser.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import { exec } from 'node:child_process';
1111
import { promisify } from 'node:util';
1212
import { logger } from '@rsdoctor/utils/logger';
13-
import open from 'open';
1413
import { join } from 'node:path';
1514

1615
const execAsync = promisify(exec);
@@ -48,8 +47,7 @@ export async function openBrowser(
4847
// requested a different browser, we can try opening
4948
// a Chromium browser with AppleScript. This lets us reuse an
5049
// existing tab when possible instead of creating a new one.
51-
const shouldTryOpenChromeWithAppleScript =
52-
process.platform === 'darwin' || process.platform === 'win32';
50+
const shouldTryOpenChromeWithAppleScript = process.platform === 'darwin';
5351
if (shouldTryOpenChromeWithAppleScript) {
5452
try {
5553
const targetBrowser = await getTargetBrowser();
@@ -75,6 +73,7 @@ export async function openBrowser(
7573
// Fallback to open
7674
// (It will always open new tab)
7775
try {
76+
const { default: open } = await import('open');
7877
await open(url);
7978
return true;
8079
} catch (err) {

pnpm-lock.yaml

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)