Skip to content

Commit f591498

Browse files
committed
Fix after with iterator
1 parent 3d37836 commit f591498

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

integration/test_iterator.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,11 +221,10 @@ def test_iterator_with_after(collection_factory: CollectionFactory) -> None:
221221
collection.data.insert_many([DataObject(properties={"data": i}) for i in range(10)])
222222

223223
uuids = [obj.uuid for obj in collection.iterator()]
224+
obj6 = collection.query.fetch_object_by_id(uuids[6])
224225
iterator = collection.iterator(after=uuids[5])
225-
assert (
226-
next(iterator).properties["data"]
227-
== collection.query.fetch_object_by_id(uuids[6]).properties["data"]
228-
)
226+
next_object = next(iterator)
227+
assert next_object.properties["data"] == obj6.properties["data"]
229228

230229

231230
def test_iterator_with_filter(collection_factory: CollectionFactory) -> None:

weaviate/collections/iterator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ class _IteratorInputs(Generic[TProperties, TReferences]):
4040

4141

4242
def _parse_after(after: Optional[UUIDorStr]) -> UUIDorStr:
43-
return "" if after is None or isinstance(after, UUID) else UUID(after)
43+
if after is None:
44+
return ""
45+
46+
return UUID(after) if not isinstance(after, UUID) else after
4447

4548

4649
class _ObjectIterator(

0 commit comments

Comments
 (0)