Skip to content
This repository was archived by the owner on Aug 6, 2021. It is now read-only.
This repository was archived by the owner on Aug 6, 2021. It is now read-only.

Doesn't seem to obey safety_assured blocks #2

@ibrahima

Description

@ibrahima

Hi! First of all, thanks for making this rubocop cop! I was about to make something similar after our 2nd or 3rd incident of brief downtime caused by an unsafe migration, but then I found this and was happy to see that it just uses strong_migrations for checking the migrations.

One thing though, it doesn't seem like the linter knows to ignore migrations that are wrapped in safety_assured. Is it supposed to, or is that just not implemented? I wasn't quite sure from looking at the code, but if it's just not implemented yet I might be able to find some time to work on a PR.

Thanks again!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions