Doesn't Successfully Remove Last Name

[lotap]

When I tried to remove the last name from my profile, the UI would optimistically show the change but would revert on refresh.

The convex update is successful, but clerk fails mostly silently.

vibeapps/src/pages/UserProfilePage.tsx

Lines 562 to 578 in 8c90da0

	if (nameChanged && authUser && authUser.update) {
	try {
	// Split name into first and last for Clerk
	const nameParts = newName.trim().split(" ");
	const firstName = nameParts[0] || "";
	const lastName = nameParts.slice(1).join(" ") || "";
	await authUser.update({
	firstName: firstName,
	lastName: lastName,
	});
	} catch (clerkError) {
	console.warn("Clerk name update failed:", clerkError);
	// Don't fail the whole operation if Clerk update fails
	// The Convex update already succeeded
	}
	}

I tested it again in my browser after finding that code and can confirm that I see the warning logged.

If this is a hard requirement for clerk, maybe the name field should be split to first / last with both required.

Happy to help with a PR if you would like one

[waynesutton]

@lotap thanks for catching that. Yes if you want to help out with a PR that would be great.

[waynesutton]

Hi @lotap, thanks for identifying this issue and proposing the fix!

I've implemented the same solution directly:

• Only include lastName in the Clerk update if it's not empty
• This prevents the silent Clerk error when users want just a first name

The fix is now in the codebase and deployed. Feel free to test. Thanks

[lotap]

Hi @waynesutton, thanks for looking into this!

Unfortunately your fix doesn't work. The underlying issue is that the convex db and the clerk implementation have different requirements. The clerk implementation requires a first and last name and the convex db only has a single name field.

The hotfix removes the error logged in the console but doesn't update the clerk database. So if you remove a last name in the UI it gives no indication of failure, but the change is not actually persisted.

The "real" way to fix this would be to update the clerk and convex db to use the same format for name, but that may come with data migrations.

The simple solution is to update the UI with an additional field for last name and to check that first name and last name are not empty if one of them has changed

      // Check if name changed
      const newName = `${newFirstName.trim()} ${newLastName.trim()}`
      nameChanged = newName !== currentName;

      // Early return if name is incompatible with clerk configuration
      if (
        nameChanged &&
        (newFirstName.trim() === "" || newLastName.trim() === "")
      ) {
        throw new Error("First and last name are both required.")
      }

You can see the complete context of that snippet in https://github.com/waynesutton/vibeapps/pull/12/files