Skip to content

Bring Magento template up-to-date #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Bring Magento template up-to-date #18

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a48995
Bring Magento template up-to-date
navarr Feb 22, 2024
4fc52ce
Specify XDebug 3
navarr Feb 22, 2024
be0edc6
Update install command to appropriately set backend frontname to `admin`
navarr Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .warden/commands/bootstrap.cmd
View file
Open in desktop
Copy link

@marciomaciel marciomaciel Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be nice if the script automatic check the .env file and identify if it set elasticsearch or opensearch as search engine.

Copy link

@marciomaciel marciomaciel Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add elasticsearch setup parameters to INSTALL_FLAGS

Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ elif [[ ${CLEAN_INSTALL} ]]; then

INSTALL_FLAGS="${INSTALL_FLAGS} \
--cleanup-database \
--backend-frontname=backend \
--backend-frontname=admin \
Copy link
Contributor

@hardyjohnson hardyjohnson Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably pair with an issue in the docs repo to update the references to backend.

Copy link
Contributor

@hardyjohnson hardyjohnson Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also requires update to line 29

warden-env-magento2/.warden/commands/bootstrap.cmd

Line 29 in 51e4c07

URL_ADMIN="https://${TRAEFIK_SUBDOMAIN}.${TRAEFIK_DOMAIN}/backend/"

Copy link
Contributor

@hardyjohnson hardyjohnson Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update this repo's readme.md table for AdminURLs all reference backend as well.

--db-host=db \
--db-name=magento \
--db-user=magento \
Expand Down