Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow metrics from libwaku #3202

Open
Ivansete-status opened this issue Dec 9, 2024 · 0 comments
Open

chore: allow metrics from libwaku #3202

Ivansete-status opened this issue Dec 9, 2024 · 0 comments
Assignees
Labels
effort/weeks Estimated to be completed in a few weeks

Comments

@Ivansete-status
Copy link
Collaborator

Background

We are currently disabling metrics support when building libwaku to work within Status. We did that to temporarily prevent spamming errors to happen. However, we need a proper solution for that so that the metrics will also be available from within the Status app, f.e.

Details

We need to make sure the metrics objects are created by the same thread that populates them. What is happening now is that the metrics objects are being created by the main thread whereas they are populated by The Waku Thread (see)

Instead, we need The Waku Thread to both create such metrics and populate them.

@gabrielmer gabrielmer added the effort/weeks Estimated to be completed in a few weeks label Dec 23, 2024
@gabrielmer gabrielmer moved this to In Progress in Waku Dec 23, 2024
@gabrielmer gabrielmer self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/weeks Estimated to be completed in a few weeks
Projects
Status: In Progress
Development

No branches or pull requests

2 participants