Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Filter request ID isn't unique #3169

Open
AYAHASSAN287 opened this issue Nov 3, 2024 · 1 comment
Open

bug: Filter request ID isn't unique #3169

AYAHASSAN287 opened this issue Nov 3, 2024 · 1 comment
Labels
bug Something isn't working effort/days Estimated to be completed in a few days, less than a week

Comments

@AYAHASSAN287
Copy link
Collaborator

AYAHASSAN287 commented Nov 3, 2024

Problem

According to specs filter request ID is a must to be unique
Image
but when creating many filter requests with same ID either from the same node or multiple nodes no issues or warnings occur

To reproduce

Scenario 1
1- Create 5 nodes [ node1 --> sender // node2 --> filter node // nodes3-5 making filter requests to node2]
2- Make 3 filter requests with "requestId": "1"

Expected behavior

Any errors or preventing the multiple requests with same ID

Actual behavior

requests work fine


scenario 2
1- Create 3 nodes [ node1 --> sender // node2 --> filter node // node 3 making repeated filter requests to node2
2- Make 3 filter requests with "requestId": "1" from node3

Expected behavior

Any errors or preventing the multiple requests with same ID

actual behavior

Requests work fine

nwaku version/commit hash

507b1fc

@AYAHASSAN287 AYAHASSAN287 added the bug Something isn't working label Nov 3, 2024
@SionoiS
Copy link
Contributor

SionoiS commented Nov 20, 2024

AFAIK we don't keep track of requestId even if the spec say so. Let me check the code to be sure.

edit: Indeed the requestId is never even verified.

Is this just an annoyance for you @AYAHASSAN287 or does this break your code?

@Ivansete-status Ivansete-status moved this to To Do in Waku Dec 2, 2024
@Ivansete-status Ivansete-status added the effort/days Estimated to be completed in a few days, less than a week label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/days Estimated to be completed in a few days, less than a week
Projects
Status: To Do
Development

No branches or pull requests

3 participants