Skip to content

feat!: re-work messaging parts and sharding#2353

Closed
weboko wants to merge 7 commits intomasterfrom
weboko/enc-dec-breaking
Closed

feat!: re-work messaging parts and sharding#2353
weboko wants to merge 7 commits intomasterfrom
weboko/enc-dec-breaking

Conversation

@weboko
Copy link
Copy Markdown
Collaborator

@weboko weboko commented Apr 13, 2025

Description

Due to root message related types (i.e IDecodedMessage) we incur some inefficiency and lack of needed properties.

Proposed Solution / Feature Design

We need to do couple of things to hide complexity of types and make them more consumer firendly:

  • avoid specifying IDecodedMessage over and over;
  • make meta setter hidden and part of LightPush API to be more compatible with Messaging API;
  • ensure types of decoders are used;
  • establish idecodedmessage type;

Notes


Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 62.06 KB (+0.12% 🔺) 1.3 s (+0.12% 🔺) 6.3 s (-16.7% 🔽) 7.5 s
Waku Simple Light Node 114.82 KB (-0.01% 🔽) 2.3 s (-0.01% 🔽) 8.9 s (-25.46% 🔽) 11.2 s
ECIES encryption 23.01 KB (+0.04% 🔺) 461 ms (+0.04% 🔺) 2.8 s (-38.62% 🔽) 3.2 s
Symmetric encryption 22.44 KB (-0.03% 🔽) 449 ms (-0.03% 🔽) 4.2 s (-5.27% 🔽) 4.7 s
DNS discovery 50.83 KB (0%) 1.1 s (0%) 7.5 s (-2.28% 🔽) 8.6 s
Peer Exchange discovery 51.38 KB (0%) 1.1 s (0%) 5.4 s (+1.46% 🔺) 6.4 s
Local Peer Cache Discovery 44.7 KB (0%) 894 ms (0%) 5.5 s (-5.61% 🔽) 6.4 s
Privacy preserving protocols 52.98 KB (+0.08% 🔺) 1.1 s (+0.08% 🔺) 6.8 s (+30.75% 🔺) 7.8 s
Waku Filter 54.86 KB (-0.11% 🔽) 1.1 s (-0.11% 🔽) 6.8 s (-5.27% 🔽) 7.9 s
Waku LightPush 52.29 KB (0%) 1.1 s (0%) 5.3 s (-55.89% 🔽) 6.4 s
History retrieval protocols 52.61 KB (0%) 1.1 s (0%) 8.8 s (+75.69% 🔺) 9.9 s
Deterministic Message Hashing 7.33 KB (0%) 147 ms (0%) 2.6 s (+71.9% 🔺) 2.7 s

@weboko weboko changed the title feat!: re-work messaging parts feat!: re-work messaging parts and sharding Apr 14, 2025
@weboko weboko mentioned this pull request May 20, 2025
4 tasks
@weboko weboko marked this pull request as ready for review May 20, 2025 14:56
@weboko weboko requested a review from a team as a code owner May 20, 2025 14:56
@weboko
Copy link
Copy Markdown
Collaborator Author

weboko commented May 31, 2025

Closed in favor of #2399

@weboko weboko closed this May 31, 2025
@weboko weboko deleted the weboko/enc-dec-breaking branch May 31, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: improve messaging types and sharding

1 participant