Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HealthManager should be used for all protocol-level & overall health status #2197

Closed
danisharora099 opened this issue Dec 16, 2024 · 2 comments
Assignees

Comments

@danisharora099
Copy link
Collaborator

Problem

For any js-waku consumer, getting to know how to react/respond to certain protocol health status is crucial. Example: if LightPush has 0 peers, while Filter has >0 peers, Filter works for that node while LightPush does not. This is crucial information for the consumer apps that is hard to aggregate and find. For this, we introduced HealthManager

During the last release ([email protected]), we made some hot fixes which in turn removed usage of protocols' peer management out of PeerManager, thus impacting HealthManager's abilities to report correct information.

Solution

Readjust protocols to correctly report data back to the HealthManager.

cc @vpavlin

@chair28980 chair28980 added this to Waku Dec 16, 2024
@weboko weboko moved this to Triage in Waku Dec 16, 2024
@weboko
Copy link
Collaborator

weboko commented Dec 18, 2024

Ice boxed for now, to be revisited after PeerManager is done.

@weboko weboko moved this from Triage to Icebox in Waku Dec 18, 2024
@danisharora099
Copy link
Collaborator Author

Ice boxed for now, to be revisited after PeerManager is done.

is there an exact issue/milestone that encompasses this work around the PeerManager? can you share? thank you!

@weboko weboko moved this from Icebox to In Progress in Waku Feb 4, 2025
@weboko weboko self-assigned this Feb 4, 2025
@weboko weboko moved this from In Progress to Code Review / QA in Waku Feb 4, 2025
@weboko weboko moved this from Code Review / QA to Done in Waku Feb 5, 2025
@weboko weboko closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants