Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making auto_quote system false by default #48

Open
VictorShima opened this issue Mar 20, 2018 · 1 comment
Open

Making auto_quote system false by default #48

VictorShima opened this issue Mar 20, 2018 · 1 comment

Comments

@VictorShima
Copy link

First of, Thank you very much for working on this plugin!

When using auto_quote: true the following piece of CSV will have its quotes removed when a CSV > Compact columns is used:

oranges,"tasty
fruits"
apples,"delicious treats"

Becomes:

oranges,tasty
fruits
apples,delicious treats

It seems like the command is not respecting line breaks inside quotes, turning a valid CSV with 2 rows into an invalid CSV with 3 rows. The Section 2.6 of a CSV Standard describes the usage of line breaks inside quotes.

Removing the auto_quote configuration makes it work wonderfully out-of-the-box. Other issues also seem to suggest that the auto_quote is having couple of edge cases and past problems.

Would you consider making auto_quote disabled on default?

@wadetb
Copy link
Owner

wadetb commented Mar 28, 2018

Hi @VictoryShima - thanks for the report! I'll investigate the bugs with auto quote and will consider disabling it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants