Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One person can forfeit 4v4 in a team of 2 #17

Open
Mutantx opened this issue Mar 5, 2023 · 0 comments · May be fixed by #18
Open

One person can forfeit 4v4 in a team of 2 #17

Mutantx opened this issue Mar 5, 2023 · 0 comments · May be fixed by #18

Comments

@Mutantx
Copy link

Mutantx commented Mar 5, 2023

Description

When team of 4 drops to 2, if one person types -gg it forfeits game instantly. This removes the ability for teammate to play 1v1/2/3/4.
In this scenario it should propose Forfeit to teammate instead of immediate Defeat.
One person's opinion on viability of game shouldn't end it.

When a player leaves following continues to drop:

requiredForfeitPlayers[team] = requiredForfeitPlayers[team] - 1;

Possible Implementation

When someone leaves (leaveTrigger), prevent 1 person from deciding fate of game by adding conditional statement:

if (requiredForfeitPlayers[team] > 2){
    requiredForfeitPlayers[team] = requiredForfeitPlayers[team] - 1;
}
@Mutantx Mutantx linked a pull request Mar 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant