Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red square around W3C Logo? #1267

Closed
egekorkan opened this issue Nov 4, 2021 · 9 comments
Closed

Red square around W3C Logo? #1267

egekorkan opened this issue Nov 4, 2021 · 9 comments
Labels
Editorial Issues with no technical impact on implementations Propose closing Problem will be closed shortly if there is no veto. V1.1 should be resolved in v1.1

Comments

@egekorkan
Copy link
Contributor

In all WoT specifications, I am seeing a red border around the W3C logo. Is it only me? I have checked with multiple browsers and private modes and smartphone, still the same behavior. The title is also black instead of blue.
image

@benfrancis
Copy link
Member

I've seen this too. Is this a respec bug/feature?

@JKRhb
Copy link
Member

JKRhb commented Nov 4, 2021

It seems to be a style specific to Editor's Drafts if I am not mistaken. The TD recommendation and the latest Working Draft don't have the red border, at least in my case.

@relu91
Copy link
Member

relu91 commented Nov 4, 2021

Same here, tested with the current draft

@egekorkan
Copy link
Contributor Author

@ashimura can you investigate this?

@ashimura
Copy link
Contributor

ashimura commented Nov 5, 2021

If you add "&specStatus=WD" after the github.io URL (=https://w3c.github.io/wot-thing-description/?specStatus=WD), the logo doesn't have the red border.

On the other hand, if you click the "ReSpec" button on the right above of the ED draft and save the resulted HTML by clicking "Export" (and then "HTML"), you can tell:

  1. The resulted HTML includes:
    <link rel="stylesheet" href="https://www.w3.org/StyleSheets/TR/2021/W3C-ED">
    and:
    <a class="logo" href="https://www.w3.org/"><img crossorigin="" alt="W3C" height="48" src="https://www.w3.org/StyleSheets/TR/2021/logos/W3C" width="72"></a>
  2. And the CSS file above says "--logo-bg: red;".

I think that's why the Editors Drafts have the red border around the W3C logo.

If you don't like that behavior, maybe you can raise an issue at:
https://github.com/w3c/respec/issues

@egekorkan
Copy link
Contributor Author

Thanks for the explanations @ashimura ! Is this the desired behavior or have we misconfigured something? Some specs I find do not have this but all our specs got it without any code change from our side. Some that look like before:

Some that look like ours:

Some specs do not even use the W3C logo:

@ashimura
Copy link
Contributor

ashimura commented Nov 8, 2021

If you look at the Web pages of:

there no "ReSpec" button at the right top.

Also if you look into the source HTML files of those pages, there is no reference for ReSpec.

So those two drafts above don't use ReSpec and are static HTML files.

I'd suggest you quickly skim the source HTML files of the specs before raising an Issue on GitHub :)

@k-toumura
Copy link
Contributor

A similar issue has also been raised in w3c/tr-design#268 .

@egekorkan egekorkan added Editorial Issues with no technical impact on implementations V1.1 should be resolved in v1.1 labels Jun 15, 2022
@sebastiankb sebastiankb added the Propose closing Problem will be closed shortly if there is no veto. label Jul 20, 2022
@egekorkan
Copy link
Contributor Author

Call of 30.11: As decided before, this does not appear on WDs but only on Editor's Drafts. We can ignore and simply close the issue.

@egekorkan egekorkan closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Issues with no technical impact on implementations Propose closing Problem will be closed shortly if there is no veto. V1.1 should be resolved in v1.1
Projects
None yet
Development

No branches or pull requests

7 participants