Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serializeBaseProofValue text mentions 5 elements, but there are just 3 #120

Closed
dlongley opened this issue Jan 11, 2024 · 2 comments
Closed
Assignees

Comments

@dlongley
Copy link
Contributor

https://w3c.github.io/vc-di-bbs/#serializebaseproofvalue

This:

Initialize components to an array with five elements containing the values of: bbsSignature, hmacKey, and mandatoryPointers.

Should say:

Initialize components to an array with three elements containing the values of: bbsSignature, hmacKey, and mandatoryPointers.

@dlongley
Copy link
Contributor Author

Similar text here needs updating ("five" => "four"):

https://w3c.github.io/vc-di-bbs/#serializederivedproofvalue

From:

Return derived proof value as an object with properties set to the five elements, using the names "bbsProof", "labelMap", "mandatoryIndexes", and "selectiveIndexes" respectively.

To:

Return derived proof value as an object with properties set to the four elements, using the names "bbsProof", "labelMap", "mandatoryIndexes", and "selectiveIndexes" respectively.

@dlongley
Copy link
Contributor Author

dlongley commented Feb 7, 2024

This was my issue and it was addressed by #124, closing.

@dlongley dlongley closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants