-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-overflow] Invisible line boxes and line-clamp
#11021
Comments
I'd say there's two parts:
|
Well, maybe a third part:
|
The spec for invisible line boxes says:
We don't want to mention invisible line boxes everywhere we mention line boxes. That would make our specs unnecessarily hard to read. These are effectively |
This lines up closer to CSS2 terminology. Related to #11021
While talking with @kojiishi earlier today, we noticed that the spec text for
block-ellipsis
andmax-lines
(which are shorthands ofline-clamp
) talks about line boxes in general, without explicitly excluding invisible line boxes. But currently every browser ignores invisible line boxes for(-webkit-)line-clamp
, clamping at "Line 4" in this example:Aside from this, there's the question of how to take into account invisible line boxes when clamping based on a height. With
continue: discard
it is possible for an invisible line box to be "immediately preceding a region break" (see also #10868), which per the spec means it should be ellipsized. However, it would be very unexpected to have an ellipsis placed there. Withcontinue: discard
, I think the previous line box, if there is one, should have the ellipsis.For
continue: collapse
, in TPAC we agreed that this variant ofline-clamp
would only allow clamping immediately after a line box, whereascontinue: discard
could clamp between lineless blocks (see #10816 (comment)). This should be changed to only allow clamping immediately after a visible line box.cc @frivoal @emilio
The text was updated successfully, but these errors were encountered: