Add parameters latency_tracking & repl_diskless_sync#540
Add parameters latency_tracking & repl_diskless_sync#540hdep wants to merge 18 commits intovoxpupuli:masterfrom
Conversation
|
currently I don't understand why I got this failing in CI : |
TheMeier
force-pushed
the
add_parameters
branch
from
03aebb6 to
e722e04
Compare
|
|
||
| $bind_arr = [$bind].flatten | ||
|
|
||
| $default_redis_version = '8.0.0' |
There was a problem hiding this comment.
Do we really need the version magic?
Version facts are quite opaque and lead to non-idempotent behaviour
There was a problem hiding this comment.
those new parameters are from version 7.0.0, so I was looking for a way to keep old setup working, and providing a new config file for setup with redis version > 7.0
There was a problem hiding this comment.
So these configs are available in redis 7.x? Anything below 7.4 is EOL so we could just drop the version condition completely
There was a problem hiding this comment.
I see repl-diskless-sync and latency-tracking in here https://raw.githubusercontent.com/redis/redis/7.4/redis.conf
TheMeier
force-pushed
the
add_parameters
branch
from
e722e04 to
71e1098
Compare
2 participants
Pull Request (PR) description
this PR add two parameters into redis.conf :
repl-diskless-sync
latency-tracking
https://raw.githubusercontent.com/redis/redis/7.0/redis.conf
This Pull Request (PR) fixes the following issues
Fixes #531