Skip to content

Commit bbdcdb7

Browse files
committed
raise default version to 1.16.0
this fixes the acceptance tests. But there is a bigger issue here. The code in manifests/init.pp is not idempotent: ``` String[1] $nginx_version = pick(fact('nginx_version'), '1.6.0'), ``` Turns out on the first run the fact might not be set yet leading to a pre 1.15.0 compatible configuration on systems wich ship a newer version of nginx. Leading to ``` nginx: [emerg] unknown directive "ssl" in /etc/nginx/sites-enabled/www.puppetlabs.com.conf:25 ```
1 parent bbfff0a commit bbdcdb7

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.rspec

+1
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,4 @@
33

44
--format documentation
55
--color
6+
--fail-fast

manifests/init.pp

+1-1
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@
240240
Hash $nginx_upstreams = {},
241241
Nginx::UpstreamDefaults $nginx_upstreams_defaults = {},
242242
Boolean $purge_passenger_repo = true,
243-
String[1] $nginx_version = pick(fact('nginx_version'), '1.6.0'),
243+
String[1] $nginx_version = pick(fact('nginx_version'), '1.16.0'),
244244

245245
### END Hiera Lookups ###
246246
) inherits nginx::params {

0 commit comments

Comments
 (0)