Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search domains option to dhcp::pool #89

Open
domcleal opened this issue Jun 17, 2016 · 2 comments
Open

Add search domains option to dhcp::pool #89

domcleal opened this issue Jun 17, 2016 · 2 comments

Comments

@domcleal
Copy link
Contributor

domcleal commented Jun 17, 2016

dhcp::pool should have a search domains parameter that sets the domain-search option in the pool to a list of DNS domains. It should accept a single domain or an array.

Based on theforeman/puppet-dhcp@1ad54b3 and theforeman/puppet-dhcp@c961257.

@alexjfisher
Copy link
Member

@domcleal Apologies, but I didn't notice this issue until after I'd merged #96

Does #96 work for you, or do you need improvements? I guess since we've not done a release yet, we can change the parameter name if needed.

@domcleal
Copy link
Contributor Author

Ideally there would (also) be a parameter on dhcp::pool to match the impl that we merged into theforeman. I don't think we can reasonably match parameter names between the two modules, so I think it's fine - we can do the same to dhcp::pool.

@domcleal domcleal modified the milestone: theforeman/dhcp parity Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants