Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DependencyNotInstalled on modules that requires sqlalchemy #162

Closed
perdy opened this issue Nov 25, 2024 · 0 comments · Fixed by #163
Closed

DependencyNotInstalled on modules that requires sqlalchemy #162

perdy opened this issue Nov 25, 2024 · 0 comments · Fixed by #163
Assignees
@perdy
Labels
bug Something isn't working

Comments

@perdy
Copy link
Member

perdy commented Nov 25, 2024

Summary

Raise a DependencyNotInstalled on modules that requires sqlalchemy

Reproduce steps

Currently some modules that requires sqlalchemy can be imported but are failing on type checking, we want to avoid this behaviour by not allowing to import those modules if sqlalchemy is not installed.

Schema library

None

Models library

None

Error logs

No response
@perdy perdy added the bug Something isn't working label Nov 25, 2024
perdy added a commit that referenced this issue Nov 25, 2024
@perdy
🐛 DependencyNotInstalled on modules that requires sqlalchemy (#162)
f1cc46a
@perdy perdy linked a pull request Nov 25, 2024 that will close this issue
1.9.1 #163
Merged
perdy added a commit that referenced this issue Nov 25, 2024
@perdy
🐛 DependencyNotInstalled on modules that requires sqlalchemy (#162)
c8bc76a
perdy added a commit that referenced this issue Nov 25, 2024
@perdy
🐛 DependencyNotInstalled on modules that requires sqlalchemy (#162)
e7ab2f4
github-actions bot pushed a commit that referenced this issue Nov 25, 2024
@semantic-release-bot
🔖 1.9.1 [skip ci]
2498889 
# [v1.9.1](v1.9.0...v1.9.1) (2024-11-25)

## 🐛 Bug Fixes
- [`e7ab2f4`](e7ab2f4)  DependencyNotInstalled on modules that requires sqlalchemy (#162) (Issues: [`#162`](https://github.com/vortico/flama/issues/))
@perdy perdy self-assigned this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perdy perdy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.9.1 vortico/flama
1 participant
@perdy