-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Need to specify middleware and path for /mails endpoint #8
Comments
Not sure what the best practice is for a Filament package. Also not sure if this is possible:
We’ll probably find out. @baoc75 curious what you mean with “exporting routes” or how you see the solution. |
Adding the current panel path to the url should be possible using some of the methods like |
Protecting your routes by middleware or tenant routes is now described here @baoc75 : It's also possible to add the routes to your own routes file (e.g. // routes\web.php
use Vormkracht10\FilamentMails\Facades\FilamentMails;
FilamentMails::routes(); This is a breaking change so we made it available at version v2.0.0. |
Awesome thank you! I am gonna implement it now @Baspa @markvaneijk |
What happened?
I expect to see the email preview
Additionally, since this is part of internal admin panel, I expect the route path should starts with /admin and is protected with middleware. I think we should allow exporting routes. In my case, I am building a multi-tenant app that has middleware to decide which database to use.
This issue affect all areas that call to /mails endpoint.
How to reproduce the bug
When I go to

admin/mails
and the modal show up, I press on Preview tab and it show the errorsError traces: https://flareapp.io/share/J7oXaod5
Package Version
1.0.5
PHP Version
8.3.4
Laravel Version
11.32.0
Which operating systems does with happen with?
Windows
Notes
No response
The text was updated successfully, but these errors were encountered: