Skip to content

keepalive API: Inconsistent message field causes client to miss PING Success log #32

@gh-db

Description

@gh-db

Hi, thanks for your great project!

I found a small issue with the /process_send_keepalive/send_keepalive API:

The message field in the response sometimes returns "ping recored" and sometimes "ping recored." and sometimes "ping recored..".
This inconsistency causes client code to miss logging "PING Success" because it checks for an exact match(keepalive.get("message") == "ping recored").

Example responses:
{"success":true,"message":"ping recored.","data":"ping recorded","s":"ping11"}
{"success":true,"message":"ping recored.","data":"ping recorded","s":"ping12"}
{"success":true,"message":"ping recored..","data":"ping recorded","s":"ping13"}

Suggestion:
To avoid similar issues, I recommend that clients use substring or pattern matching (e.g., if "ping recored" in message) instead of exact string comparison when checking the message field.

Thank you!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions