You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The _query_sync function returns a dict when recipe.query_ready is false, but the query MCP tool expects a string return type. This will cause a runtime error when the query tool is used without LLM config.
ifnotrecipe.query_ready:
return {
"answer": (
"Query is not configured on this MCP bridge. ""Provide a local ov.conf with vlm.api_base and vlm.model, ""or use the search tool and let Codex synthesize the answer."
),
"context": [],
"timings": {},
}
The search method calls self.client.stat() for each search result to retrieve timestamps, leading to N additional roundtrips. This can degrade performance when many results are returned.
The _replay_offline_sessions function uses broad except Exception: clauses without logging, which hides errors during offline session replay and makes debugging difficult.
exceptException:
continueifnotturns:
turns_file.unlink(missing_ok=True)
continuetry:
withOVClient(backend, ov_conf_path) ascli:
sess=cli.create_session()
sid=_as_text(sess.get("session_id"))
ifnotsid:
continuefortinturns:
cli.add_message(sid, t["role"], t["content"])
cli.commit_session(sid)
turns_file.unlink(missing_ok=True)
replayed+=1exceptException:
break# server may have gone offline mid-replay
The set -e flag was removed from the common.sh script, which means the script will continue executing even if a command fails, potentially leading to unexpected behavior.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserves the current local OpenViking repo state in a dedicated capture branch.