Skip to content

Commit fdb1f1d

Browse files
committed
fix(ci): restore standalone oxlint/oxfmt and use vp fmt --check
The migration replaced standalone oxfmt/oxlint with vite-plus, whose oxfmt/oxlint bins are IDE/LSP wrappers that refuse to run as CLIs. That broke two CI jobs: 'Format and Check Deps' (pnpm oxfmt --check hit the wrapper) and 'Test' on every platform (crates/fspy/tests/oxlint.rs runs packages/tools/node_modules/.bin/oxlint and asserts it reads the JS file, but the wrapper never does). Restore oxfmt/oxlint/oxlint-tsgolint in the catalog and in packages/tools (dropping vite-plus there so its wrappers stop shadowing the real bins), and switch CI's format check to 'pnpm exec vp fmt --check'. packages/tools is a test-fixtures package that must ship the real binaries the fspy suite traces, so it cannot be migrated to vite-plus. Verified locally: vp fmt --check (522 files) and pnpm dedupe --check pass; the 3 fspy oxlint tests pass.
1 parent bbbac13 commit fdb1f1d

4 files changed

Lines changed: 315 additions & 8 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ jobs:
262262
components: clippy rust-docs rustfmt
263263

264264
- uses: oxc-project/setup-node@ab97f03642370d79a7e96dd286bd02a1be40e0ba # v1.3.0
265-
- run: pnpm oxfmt --check
265+
- run: pnpm exec vp fmt --check
266266
- run: cargo autoinherit && git diff --exit-code
267267
- run: cargo shear --deny-warnings
268268
- run: cargo fmt --check

packages/tools/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
"private": true,
44
"type": "module",
55
"dependencies": {
6-
"cross-env": "^10.1.0"
7-
},
8-
"devDependencies": {
9-
"vite-plus": "catalog:"
6+
"cross-env": "^10.1.0",
7+
"oxfmt": "0.42.0",
8+
"oxlint": "catalog:",
9+
"oxlint-tsgolint": "catalog:"
1010
}
1111
}

0 commit comments

Comments
 (0)