Skip to content

feat(migrate): upgrade pack config for tsdown 0.23 - #2614

Merged
fengmk2 merged 7 commits into
mainfrom
feat/migrate-tsdown-023
Sep 7, 2026
Merged

feat(migrate): upgrade pack config for tsdown 0.23#2614
fengmk2 merged 7 commits into
mainfrom
feat/migrate-tsdown-023

Conversation

@fengmk2

@fengmk2 fengmk2 commented Sep 5, 2026

Copy link
Copy Markdown
Member

vp migrate upgrades legacy pack options for tsdown@0.23.0. This includes existing Vite+ projects without --full.

The command renames removed options, updates declaration generators, and replaces --public-dir with --copy. It also moves noExternal to deps.alwaysBundle and preserves matcher expressions and references. It handles concise arrow callbacks and options written as methods. It preserves explicit values and makes the previous defaults for dependency resolution and ATTW checks explicit.

The migration preserves external matching with both forms of skipNodeModulesBundle. Unsupported combinations keep their pack options and show a manual migration warning.

Ecosystem CI now uses migration for the pinned vinext pack config. The core build removes obsolete ansis logger patches.

Tests cover standalone and JSON configs, workspace packages, and repeated migration. Build tests check external imports, separate output files, custom extensions, copied assets, and declarations.

@netlify

netlify Bot commented Sep 5, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview ready!

Name Link
🔨 Latest commit 8443d31
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a9e255e8dd0a2000874c0ee
😎 Deploy Preview https://deploy-preview-2614--viteplus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 5, 2026

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://feat-migrate-tsdown-023-viteplus-dev.voidzero-docs.workers.dev (commit 8443d31)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://2eed67c8-viteplus-dev.voidzero-docs.workers.dev 8443d31 2026-09-07T02:47:25.140Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://a19bd01a-viteplus-dev.voidzero-docs.workers.dev 8d1aa84 2026-09-07T02:17:27.178Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d202d7bb-viteplus-dev.voidzero-docs.workers.dev 2d07b6c 2026-09-06T15:34:05.162Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://d18f174b-viteplus-dev.voidzero-docs.workers.dev db2b2f6 2026-09-06T15:25:59.712Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9f4fd422-viteplus-dev.voidzero-docs.workers.dev 41112b9 2026-09-06T14:58:30.635Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://45582498-viteplus-dev.voidzero-docs.workers.dev b7ce5fc 2026-09-06T14:38:52.735Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://5f9a35db-viteplus-dev.voidzero-docs.workers.dev 3cc7b06 2026-09-06T14:15:00.041Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://df7221fe-viteplus-dev.voidzero-docs.workers.dev 837ad72 2026-09-06T14:08:20.062Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://bb57390b-viteplus-dev.voidzero-docs.workers.dev c0a6466 2026-09-06T03:29:01.617Z Visit the dashboard ↗
  • Build: Failed ❌

View logs ↗
7541748 2026-09-06T02:29:08.462Z View logs ↗

View all previews: View all previews ↗

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 8443d31

@socket-security

socket-security Bot commented Sep 5, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​vite-plus@​0.2.08010010099100

View full report

@socket-security

socket-security Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: npm @vitest/browser: Browser Mode provider commands bypass the file-access permission gate

CVE: GHSA-p63j-vcc4-9vmv @vitest/browser: Browser Mode provider commands bypass the file-access permission gate (CRITICAL)

Affected versions: >= 4.0.0 < 4.1.10; < 3.2.7; >= 5.0.0-beta.1 < 5.0.0-beta.6

Patched version: 4.1.10

From: crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/package.jsonnpm/vite-plus@0.2.0npm/@vitest/browser@4.1.9

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@vitest/browser@4.1.9. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

CLI artifact sizes (8443d31)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.13 MiB 2.13 MiB +119 B (+0.01%)
packages/core/dist Directory total 3.92 MiB 3.92 MiB 0 B (0.00%)
Combined package dist Directory total 6.05 MiB 6.05 MiB +119 B (+0.00%)
vp (Linux x64) Binary 10.99 MiB 10.99 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 4.76 MiB 4.76 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 31.88 MiB 31.93 MiB +56.00 KiB (+0.17%)
NAPI (Linux x64) gzip -9 12.58 MiB 12.61 MiB +24.46 KiB (+0.19%)
vp (macOS ARM64) Binary 8.19 MiB 8.19 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 4.15 MiB 4.15 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 39.50 MiB 39.55 MiB +48.42 KiB (+0.12%)
NAPI (macOS ARM64) gzip -9 16.91 MiB 16.93 MiB +20.74 KiB (+0.12%)
vp (Windows x64) Binary 8.86 MiB 8.86 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 3.88 MiB 3.88 MiB 0 B (0.00%)
NAPI (Windows x64) Binary 26.76 MiB 26.81 MiB +49.00 KiB (+0.18%)
NAPI (Windows x64) gzip -9 10.68 MiB 10.70 MiB +21.54 KiB (+0.20%)
Trampoline (Windows x64) Binary 14.00 KiB 14.00 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.09 KiB 7.09 KiB 0 B (0.00%)
Installer (Windows x64) Binary 4.50 MiB 4.50 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 2.11 MiB 2.11 MiB 0 B (0.00%)

Base automatically changed from deps/upstream-update to main September 6, 2026 02:26
@fengmk2
fengmk2 force-pushed the feat/migrate-tsdown-023 branch 2 times, most recently from c0a6466 to 837ad72 Compare September 6, 2026 14:06
@fengmk2 fengmk2 self-assigned this Sep 6, 2026
@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Sep 6, 2026
@fengmk2
fengmk2 marked this pull request as ready for review September 7, 2026 02:14
@fengmk2
fengmk2 force-pushed the feat/migrate-tsdown-023 branch from 2d07b6c to 8d1aa84 Compare September 7, 2026 02:15
@fengmk2
fengmk2 requested a review from cpojer September 7, 2026 02:16
@fengmk2

fengmk2 commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

cc @sxzz

@fengmk2
fengmk2 force-pushed the feat/migrate-tsdown-023 branch from 8d1aa84 to 8443d31 Compare September 7, 2026 02:45
@fengmk2
fengmk2 merged commit 3bbae42 into main Sep 7, 2026
112 checks passed
@fengmk2
fengmk2 deleted the feat/migrate-tsdown-023 branch September 7, 2026 03:06

@sxzz sxzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants