Commit e43f636
authored
test(snapshots): pin dev_engines_runtime_pnpm11 to the seeded default Node version (#2390)
Since 2026-08-08 the Windows PTY snapshot leg fails intermittently on
`dev_engines_runtime_pnpm11`: the `vp dlx -s print-current-version` step
times out after 60s with empty output (13+ runs across branches, main
included, e.g. [run
31302523708](https://github.com/voidzero-dev/vite-plus/actions/runs/31302523708)).
The fixture pinned devEngines node `22.22.2`, the only pin in the suite
that the CI runtime seed does not carry, so the step had to download
Node.js from nodejs.org inside its 60s budget. Connections from the
Windows runner to nodejs.org stall intermittently, and the shared HTTP
client's 2-minute request timeout (see #2386) outlives the step budget,
so a stalled attempt can neither fail nor retry in time. The sibling
`dev_engines_runtime_pnpm10` pins the seeded default `22.18.0` and
passed in ~2s in the same failed runs, which clears the npm registry
path and isolates the stall to nodejs.org.
Pin the pnpm11 fixture to `22.18.0` as well. The `22.22.2` pin carried
no assertion value: #1289 picked it as the then-latest 22.x above vp's
minimum, and the snapshot redacts the printed version to `<version>`.
The case still verifies that vp honors `devEngines.runtime` under pnpm
11. Verified with `cargo test -p vp_cli_snapshots --test cli_snapshots
-- dev_engines_runtime_pnpm11` (passes in 6s, no snapshot drift).1 parent f6e7897 commit e43f636
3 files changed
Lines changed: 7 additions & 3 deletions
File tree
- crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/dev_engines_runtime_pnpm11
- snapshots
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
4 | 8 | | |
5 | | - | |
| 9 | + | |
6 | 10 | | |
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
0 commit comments