fix(migrate): resolve constant external matchers

Author: fengmk2

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/external-conflicts.config.txt

@@ -0,0 +1,18 @@
+const externalOptions = ['foo'];
+
+export default {
+  pack: [
+    {
+      external: externalOptions,
+      skipNodeModulesBundle: true,
+      inputOptions(options) { return { external: options.external }; },
+      bundle: false,
+      dts: { tsgo: true },
+    },
+    {
+      external: externalOptions,
+      deps: { skipNodeModulesBundle: true, dts: { neverBundle: ['types'] } },
+      bundle: false,
+    },
+  ],
+};

…ration_pack_tsdown_023/manual.config.txt …tsdown_023/external-constants.config.txtcrates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/manual.config.txt renamed to crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/external-constants.config.txt crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/manual.config.txt renamed to crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/external-constants.config.txt

@@ -1,3 +1,6 @@
+const externalOptions = ['foo', './external.js'];
+const externalAlias = externalOptions;
+
 export default {
   pack: [
     {
@@ -14,5 +17,19 @@ export default {
       external: ['foo', './external.js'],
       deps: { skipNodeModulesBundle: true },
     },
+    {
+      entry: 'src/index.ts',
+      outDir: 'dist/constant',
+      dts: false,
+      external: externalOptions,
+      skipNodeModulesBundle: true,
+    },
+    {
+      entry: 'src/index.ts',
+      outDir: 'dist/alias',
+      dts: false,
+      external: externalAlias,
+      deps: { skipNodeModulesBundle: true },
+    },
   ],
 };

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/external.config.txt

@@ -35,6 +35,8 @@ steps = [
   { argv = ["vp", "pack"], snapshot = false },
   { argv = ["vpt", "print-file", "dist/top/index.mjs"] },
   { argv = ["vpt", "print-file", "dist/nested/index.mjs"] },
+  { argv = ["vpt", "print-file", "dist/constant/index.mjs"] },
+  { argv = ["vpt", "print-file", "dist/alias/index.mjs"] },
   { argv = ["vp", "migrate", "--no-interactive"] },
 ]
 
@@ -58,13 +60,23 @@ steps = [
 ]
 
 [[case]]
-name = "migration_pack_tsdown_023_manual"
+name = "migration_pack_tsdown_023_external_constants"
 vp = "global"
-comment = "Report unsupported external matchers without changing the pack options."
+comment = "Migrate constant external references with both skip forms without a manual-migration warning."
 steps = [
-  { argv = ["vpt", "cp", "manual.config.txt", "vite.config.ts"], snapshot = false },
+  { argv = ["vpt", "cp", "external-constants.config.txt", "vite.config.ts"], snapshot = false },
   { argv = ["vp", "migrate", "--no-interactive"] },
   { argv = ["vpt", "print-file", "vite.config.ts"] },
   { argv = ["vp", "migrate", "--no-interactive"] },
   { argv = ["vpt", "print-file", "vite.config.ts"] },
 ]
+
+[[case]]
+name = "migration_pack_tsdown_023_external_conflicts"
+vp = "global"
+comment = "Report conflicting dependency rules while preserving the pack options."
+steps = [
+  { argv = ["vpt", "cp", "external-conflicts.config.txt", "vite.config.ts"], snapshot = false },
+  { argv = ["vp", "migrate", "--no-interactive"] },
+  { argv = ["vpt", "print-file", "vite.config.ts"] },
+]

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/snapshots.toml

@@ -25,6 +25,9 @@ VITE+ - The Unified Toolchain for the Web
 ## `vpt print-file vite.config.ts`
 
 ```
+const externalOptions = ['foo', './external.js'];
+const externalAlias = externalOptions;
+
 export default {
   pack: [
     {
@@ -41,6 +44,20 @@ export default {
       inputOptions: { external: ['foo', './external.js'] },
       deps: { resolveDepSubpath: true, neverBundle: true },
     },
+    {
+      entry: 'src/index.ts',
+      outDir: 'dist/constant',
+      dts: false,
+      inputOptions: { external: externalOptions },
+      deps: { neverBundle: true, resolveDepSubpath: true },
+    },
+    {
+      entry: 'src/index.ts',
+      outDir: 'dist/alias',
+      dts: false,
+      inputOptions: { external: externalAlias },
+      deps: { resolveDepSubpath: true, neverBundle: true },
+    },
   ],
 };
 ```
@@ -64,6 +81,22 @@ import { externalValue } from "./external.js";
 export { externalValue, foo };
 ```
 
+## `vpt print-file dist/constant/index.mjs`
+
+```
+import { foo } from "foo";
+import { externalValue } from "./external.js";
+export { externalValue, foo };
+```
+
+## `vpt print-file dist/alias/index.mjs`
+
+```
+import { foo } from "foo";
+import { externalValue } from "./external.js";
+export { externalValue, foo };
+```
+
 ## `vp migrate --no-interactive`
 
 ```

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/snapshots/migration_pack_tsdown_023_external.md

@@ -0,0 +1,44 @@
+# migration_pack_tsdown_023_external_conflicts
+
+Report conflicting dependency rules while preserving the pack options.
+
+## `vpt cp external-conflicts.config.txt vite.config.ts`
+
+
+## `vp migrate --no-interactive`
+
+```
+VITE+ - The Unified Toolchain for the Web
+
+◇ Updated . to Vite+ <version>
+• Node <version>  npm <version>
+• Dependencies:
+    vite-plus  0.2.0 → <version>
+    vite             → <version>
+• Package manager settings configured
+! Warnings:
+  - vite.config.ts: Cannot safely combine external with skipNodeModulesBundle. Migrate this pack config manually; its options were left unchanged. See https://tsdown.dev/options/dependencies#migration-from-deprecated-options
+```
+
+## `vpt print-file vite.config.ts`
+
+```
+const externalOptions = ['foo'];
+
+export default {
+  pack: [
+    {
+      external: externalOptions,
+      skipNodeModulesBundle: true,
+      inputOptions(options) { return { external: options.external }; },
+      bundle: false,
+      dts: { tsgo: true },
+    },
+    {
+      external: externalOptions,
+      deps: { skipNodeModulesBundle: true, dts: { neverBundle: ['types'] } },
+      bundle: false,
+    },
+  ],
+};
+```

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/migration_pack_tsdown_023/snapshots/migration_pack_tsdown_023_external_conflicts.md

@@ -0,0 +1,54 @@
+# migration_pack_tsdown_023_external_constants
+
+Migrate constant external references with both skip forms without a manual-migration warning.
+
+## `vpt cp external-constants.config.txt vite.config.ts`
+
+
+## `vp migrate --no-interactive`
+
+```
+VITE+ - The Unified Toolchain for the Web
+
+◇ Updated . to Vite+ <version>
+• Node <version>  npm <version>
+• Dependencies:
+    vite-plus  0.2.0 → <version>
+    vite             → <version>
+• 1 file had imports rewritten
+• Package manager settings configured
+```
+
+## `vpt print-file vite.config.ts`
+
+```
+const externalOptions = ['foo'];
+
+export default {
+  pack: [
+    { inputOptions: { external: externalOptions }, deps: { neverBundle: true, resolveDepSubpath: true }, unbundle: true, dts: { generator: 'tsgo' } },
+    { inputOptions: { external: externalOptions }, deps: { resolveDepSubpath: true, neverBundle: true }, unbundle: true },
+  ],
+};
+```
+
+## `vp migrate --no-interactive`
+
+```
+VITE+ - The Unified Toolchain for the Web
+
+This project is already using Vite+! Happy coding!
+```
+
+## `vpt print-file vite.config.ts`
+
+```
+const externalOptions = ['foo'];
+
+export default {
+  pack: [
+    { inputOptions: { external: externalOptions }, deps: { neverBundle: true, resolveDepSubpath: true }, unbundle: true, dts: { generator: 'tsgo' } },
+    { inputOptions: { external: externalOptions }, deps: { resolveDepSubpath: true, neverBundle: true }, unbundle: true },
+  ],
+};
+```