refactor(pm): remove unused package manager selector

Author: liangmiQwQ

Cargo.lock

@@ -74,9 +74,6 @@ pub enum Error {
     #[error(transparent)]
     JoinError(#[from] tokio::task::JoinError),
 
-    #[error("User cancelled by Ctrl+C")]
-    UserCancelled,
-
     #[error("Hash mismatch: expected {expected}, got {actual}")]
     HashMismatch { expected: Str, actual: Str },
 

crates/vp_error/src/lib.rs

@@ -12,7 +12,6 @@ backon = { workspace = true }
 base64-simd = { workspace = true }
 clap = { workspace = true, features = ["derive"] }
 cow-utils = { workspace = true }
-crossterm = { workspace = true }
 flate2 = { workspace = true }
 futures-util = { workspace = true }
 hex = { workspace = true }

crates/vp_pm_cli/Cargo.toml

@@ -1,21 +1,15 @@
-#![allow(clippy::disallowed_macros, clippy::print_stdout)]
+#![allow(clippy::disallowed_macros)]
+#![cfg_attr(test, allow(clippy::print_stdout))]
 
 use std::{
     collections::HashMap,
     env, fmt,
     fs::{self, File},
-    io::{self, BufReader, Write},
+    io::{self, BufReader},
     path::{Path, PathBuf},
     time::Duration,
 };
 
-use crossterm::{
-    cursor,
-    event::{self, Event, KeyCode, KeyEvent, KeyEventKind},
-    execute,
-    style::{Color, Print, ResetColor, SetForegroundColor},
-    terminal,
-};
 use semver::Version;
 use serde::{Deserialize, Serialize};
 use tokio::fs::remove_dir_all;
@@ -260,21 +254,6 @@ impl PackageManagerBuilder {
             bin_prefix: install_dir.join("bin"),
         })
     }
-
-    /// Build the package manager with default package manager.
-    /// If the package manager is not specified, prompt the user to select a package manager.
-    pub async fn build_with_default(&self) -> Result<PackageManager, Error> {
-        let package_manager = match self.build().await {
-            Ok(pm) => pm,
-            Err(Error::UnrecognizedPackageManager) => {
-                // Prompt user to select a package manager
-                let selected_type = prompt_package_manager_selection()?;
-                Self::new(&self.cwd).package_manager_type(selected_type).build().await?
-            }
-            Err(e) => return Err(e),
-        };
-        Ok(package_manager)
-    }
 }
 
 // Version gates and migration must use the npm on PATH, not the latest registry release.
@@ -1876,223 +1855,6 @@ async fn create_bun_shim_files(bin_prefix: &AbsolutePath) -> Result<(), Error> {
     Ok(())
 }
 
-use vp_shared::is_ci_environment;
-
-/// Interactive menu for selecting a package manager with keyboard navigation
-fn interactive_package_manager_menu() -> Result<PackageManagerType, Error> {
-    let options = [
-        ("pnpm (recommended)", PackageManagerType::Pnpm),
-        ("npm", PackageManagerType::Npm),
-        ("yarn", PackageManagerType::Yarn),
-        ("bun", PackageManagerType::Bun),
-    ];
-
-    let mut selected_index = 0;
-
-    // Print header and instructions with proper line breaks
-    println!("\nNo package manager detected. Please select one:");
-    println!(
-        "   Use ↑↓ arrows to navigate, Enter to select, 1-{} for quick selection",
-        options.len()
-    );
-    println!("   Press Esc, q, or Ctrl+C to cancel installation\n");
-
-    // Enable raw mode for keyboard input
-    terminal::enable_raw_mode()?;
-
-    // Clear the selection area and hide cursor
-    execute!(io::stdout(), cursor::Hide)?;
-
-    let result = loop {
-        // Display menu with current selection
-        for (i, (name, _)) in options.iter().enumerate() {
-            execute!(io::stdout(), cursor::MoveToColumn(2))?;
-
-            if i == selected_index {
-                // Highlight selected item
-                execute!(
-                    io::stdout(),
-                    SetForegroundColor(Color::Blue),
-                    Print("▶ "),
-                    Print(format!("[{}] ", i + 1)),
-                    Print(name),
-                    ResetColor,
-                    Print(" ← ")
-                )?;
-            } else {
-                execute!(
-                    io::stdout(),
-                    Print("  "),
-                    SetForegroundColor(Color::DarkGrey),
-                    Print(format!("[{}] ", i + 1)),
-                    ResetColor,
-                    Print(name),
-                    Print("   ")
-                )?;
-            }
-
-            if i < options.len() - 1 {
-                execute!(io::stdout(), Print("\n"))?;
-            }
-        }
-
-        // Move cursor back up for next iteration
-        if options.len() > 1 {
-            execute!(io::stdout(), cursor::MoveUp((options.len() - 1) as u16))?;
-        }
-
-        // Read keyboard input, skipping non-Press events (e.g. Release on Windows)
-        let (code, modifiers) = loop {
-            if let Event::Key(KeyEvent { code, modifiers, kind, .. }) = event::read()?
-                && kind == KeyEventKind::Press
-            {
-                break (code, modifiers);
-            }
-        };
-
-        match code {
-            // Handle Ctrl+C for exit
-            KeyCode::Char('c') if modifiers.contains(event::KeyModifiers::CONTROL) => {
-                // Clean up terminal before exiting
-                terminal::disable_raw_mode()?;
-                execute!(
-                    io::stdout(),
-                    cursor::Show,
-                    cursor::MoveDown(options.len() as u16),
-                    Print("\n\n"),
-                    SetForegroundColor(Color::Yellow),
-                    Print("⚠ Installation cancelled by user\n"),
-                    ResetColor
-                )?;
-                return Err(Error::UserCancelled);
-            }
-            KeyCode::Up => {
-                selected_index = selected_index.saturating_sub(1);
-            }
-            KeyCode::Down if selected_index < options.len() - 1 => {
-                selected_index += 1;
-            }
-            KeyCode::Enter | KeyCode::Char(' ') => {
-                break Ok(options[selected_index].1);
-            }
-            KeyCode::Char('1') => {
-                break Ok(options[0].1);
-            }
-            KeyCode::Char('2') if options.len() > 1 => {
-                break Ok(options[1].1);
-            }
-            KeyCode::Char('3') if options.len() > 2 => {
-                break Ok(options[2].1);
-            }
-            KeyCode::Char('4') if options.len() > 3 => {
-                break Ok(options[3].1);
-            }
-            KeyCode::Esc | KeyCode::Char('q') => {
-                // Exit on escape/quit
-                terminal::disable_raw_mode()?;
-                execute!(
-                    io::stdout(),
-                    cursor::Show,
-                    cursor::MoveDown(options.len() as u16),
-                    Print("\n\n"),
-                    SetForegroundColor(Color::Yellow),
-                    Print("⚠ Installation cancelled by user\n"),
-                    ResetColor
-                )?;
-                return Err(Error::UserCancelled);
-            }
-            _ => {}
-        }
-    };
-
-    // Clean up: disable raw mode and show cursor
-    terminal::disable_raw_mode()?;
-    execute!(io::stdout(), cursor::Show, cursor::MoveDown(options.len() as u16), Print("\n"))?;
-
-    // Print selection confirmation
-    if let Ok(pm) = &result {
-        let name = match pm {
-            PackageManagerType::Pnpm => "pnpm",
-            PackageManagerType::Npm => "npm",
-            PackageManagerType::Yarn => "yarn",
-            PackageManagerType::Bun => "bun",
-        };
-        println!("\n✓ Selected package manager: {name}\n");
-    }
-
-    result
-}
-
-/// Prompt the user to select a package manager
-fn prompt_package_manager_selection() -> Result<PackageManagerType, Error> {
-    // In CI environment, automatically use pnpm without prompting
-    if is_ci_environment() {
-        tracing::info!("CI environment detected. Using default package manager: pnpm");
-        return Ok(PackageManagerType::Pnpm);
-    }
-
-    // Check if stdin is a TTY (terminal) - if not, use default
-    if !vp_shared::is_stdin_terminal() {
-        tracing::info!("Non-interactive environment detected. Using default package manager: pnpm");
-        return Ok(PackageManagerType::Pnpm);
-    }
-
-    // Try interactive menu first, fall back to simple prompt on error
-    match interactive_package_manager_menu() {
-        Ok(pm) => Ok(pm),
-        Err(err) => {
-            match err {
-                Error::UserCancelled => Err(err),
-                // Fallback to simple text prompt if interactive menu fails
-                _ => simple_text_prompt(),
-            }
-        }
-    }
-}
-
-/// Simple text-based prompt as fallback
-fn simple_text_prompt() -> Result<PackageManagerType, Error> {
-    let managers = [
-        ("pnpm", PackageManagerType::Pnpm),
-        ("npm", PackageManagerType::Npm),
-        ("yarn", PackageManagerType::Yarn),
-        ("bun", PackageManagerType::Bun),
-    ];
-
-    println!("\nNo package manager detected. Please select one:");
-    println!("────────────────────────────────────────────────");
-
-    for (i, (name, _)) in managers.iter().enumerate() {
-        if i == 0 {
-            println!("  [{}] {} (recommended)", i + 1, name);
-        } else {
-            println!("  [{}] {}", i + 1, name);
-        }
-    }
-
-    print!("\nEnter your choice (1-{}) [default: 1]: ", managers.len());
-    io::stdout().flush()?;
-
-    let mut input = String::new();
-    io::stdin().read_line(&mut input)?;
-
-    let choice = input.trim();
-    let index = if choice.is_empty() {
-        0 // Default to pnpm
-    } else {
-        choice
-            .parse::<usize>()
-            .ok()
-            .and_then(|n| if n > 0 && n <= managers.len() { Some(n - 1) } else { None })
-            .unwrap_or(0) // Default to pnpm if invalid input
-    };
-
-    let (name, selected_type) = &managers[index];
-    println!("✓ Selected package manager: {name}\n");
-
-    Ok(*selected_type)
-}
-
 #[cfg(test)]
 mod tests {
     use std::{fs, time::UNIX_EPOCH};

crates/vp_pm_cli/src/package_manager.rs

@@ -250,13 +250,10 @@ pub async fn run(options: CliOptions) -> Result<i32> {
 
     match result {
         Ok(exit_status) => Ok(exit_status.0.into()),
-        Err(e) => match e {
-            vp_error::Error::UserCancelled => Ok(130),
-            _ => {
-                tracing::error!("Rust error: {:?}", e);
-                Err(napi::Error::from_reason(format_error_message(&e)))
-            }
-        },
+        Err(e) => {
+            tracing::error!("Rust error: {:?}", e);
+            Err(napi::Error::from_reason(format_error_message(&e)))
+        }
     }
 }
 

packages/cli/binding/src/lib.rs

@@ -90,50 +90,9 @@ Lower-priority config files that indicate a package manager:
 
 If a caller provides a default package manager type (used internally by some code paths), that default is used with version `"latest"`.
 
-### Priority 6: Interactive selection
+Package-manager commands provide pnpm as the default, including outside a project, without prompting or creating a manifest. Without a caller-provided default, Rust detection returns an error when no manager is recognized.
 
-If no signals are detected and no default is provided, the behavior depends on the environment:
-
-#### CI environment
-
-Checks for common CI environment variables:
-
-- `CI`, `CONTINUOUS_INTEGRATION`, `GITHUB_ACTIONS`, `GITLAB_CI`, `CIRCLECI`, `TRAVIS`, `JENKINS_URL`, `BUILDKITE`, `DRONE`, `CODEBUILD_BUILD_ID` (AWS CodeBuild), `TF_BUILD` (Azure Pipelines)
-
-**Result**: Auto-selects `pnpm` without prompting.
-
-#### Non-interactive terminal
-
-If stdin is not a TTY (piped input, non-interactive shell):
-
-**Result**: Auto-selects `pnpm` without prompting.
-
-#### Interactive terminal
-
-Displays a keyboard-navigable menu:
-
-```
-No package manager detected. Please select one:
-   Use ↑↓ arrows to navigate, Enter to select, 1-4 for quick selection
-
-  ▶ [1] pnpm (recommended) ←
-    [2] npm
-    [3] yarn
-    [4] bun
-```
-
-If the interactive menu fails (terminal compatibility issues), falls back to a simple text prompt:
-
-```
-No package manager detected. Please select one:
-────────────────────────────────────────────────
-  [1] pnpm (recommended)
-  [2] npm
-  [3] yarn
-  [4] bun
-
-Enter your choice (1-4) [default: 1]:
-```
+`vp create` and `vp migrate` retain their TypeScript package-manager selector when no manager is detected. In non-interactive mode, it defaults to pnpm.
 
 ## CLI Flag: `--package-manager`
 
@@ -154,7 +113,7 @@ This ensures monorepo consistency while allowing standalone projects to override
 
 ## Non-Mutating Resolution
 
-Detection and download never rewrite `package.json`. A `devEngines.packageManager` range remains the source of truth, while lockfile, config, and interactive detection resolve a managed package manager for the current command without adding a manifest field.
+Detection and download never rewrite `package.json`. A `devEngines.packageManager` range remains the source of truth, while lockfile, config, and default detection resolve a managed package manager for the current command without adding a manifest field.
 
 Projects that require a deterministic declaration can pin it explicitly with `vp env pin <package-manager>@<version>`. Commands that modify dependencies, including `vp install` and `vp add`, require an existing `package.json` instead of creating one automatically.
 
@@ -246,7 +205,6 @@ Each package manager has specific files that trigger cache invalidation when cha
 
 - **File**: `crates/vp_pm_cli/src/package_manager.rs`
 - **Function**: `get_package_manager_type_and_version()` — priority-ordered detection
-- **Function**: `prompt_package_manager_selection()` — CI/TTY/interactive fallback
 - **Function**: `download_package_manager()` — download, hash, and record the verified pin
 - **Function**: `ensure_package_manager_bin()` — resolve the executable, shared with the global shim
 - **Function**: `verify_cached_cli_hash()` — compare a pin against the recorded pin
@@ -255,7 +213,7 @@ Each package manager has specific files that trigger cache invalidation when cha
 ### TypeScript (CLI integration)
 
 - **File**: `packages/cli/src/utils/workspace.ts` — `detectWorkspace()` wraps NAPI binding
-- **File**: `packages/cli/src/utils/prompts.ts` — `selectPackageManager()` for non-interactive default
+- **File**: `packages/cli/src/utils/prompts.ts` — `selectPackageManager()` for create/migrate prompts and the non-interactive default
 - **File**: `packages/cli/src/create/bin.ts` — `--package-manager` flag handling
 
 ### NAPI binding (bridge)