Skip to content

Commit 912a5b8

Browse files
committed
ci: remove vendored Vite test gate
1 parent 0080d52 commit 912a5b8

9 files changed

Lines changed: 7 additions & 322 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -475,13 +475,6 @@ jobs:
475475
RUST_BACKTRACE: '1'
476476
RUST_MIN_STACK: 8388608
477477

478-
- name: Test vendored Vite with Vitest v5
479-
if: runner.os == 'Linux'
480-
run: |
481-
pnpm --filter vite build-bundle
482-
pnpm --filter create-vite build
483-
pnpm test:vendored
484-
485478
- name: Test global package install (powershell)
486479
if: ${{ matrix.os != 'namespace-profile-linux-x64-default' }}
487480
shell: pwsh

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
"test": "vp test && just snapshot-test",
1717
"snapshot-test": "just snapshot-test",
1818
"test:unit": "vp test",
19-
"test:vendored": "node packages/tools/src/test-vendored-vitest.ts",
2019
"fmt": "vp fmt",
2120
"docs:dev": "pnpm -C docs dev",
2221
"docs:build": "pnpm -C docs build",

packages/tools/src/__tests__/sync-remote-deps.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515
} from '../sync-remote-deps.ts';
1616
import { alignVendoredVitestDependencies } from '../vendored-vitest.mjs';
1717

18-
describe('vendored Vitest v5 bridge', () => {
18+
describe('vendored Vitest dependency alignment', () => {
1919
test('can be imported from stdin without running the bootstrap', () => {
2020
const root = mkdtempSync(join(tmpdir(), 'vp-vendored-vitest-import-'));
2121
try {

packages/tools/src/__tests__/test-vendored-vitest.spec.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

packages/tools/src/test-vendored-vitest.ts

Lines changed: 0 additions & 99 deletions
This file was deleted.

packages/tools/src/vendored-vitest.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ export const REMOVED_VITEST_PACKAGES = new Set(['@vitest/runner', '@vitest/expec
2828
* @param {string} version
2929
*/
3030
export function alignVendoredVitestDependencies(rootDir, version) {
31-
// Vite's direct dependencies must match the root catalog for our build and
32-
// integration tests. Leave Rolldown's test dependencies to its upstream repo.
31+
// Keep Vite's direct dependencies aligned with the root catalog so sync-remote
32+
// and CI use the same lockfile. Leave Rolldown's test dependencies to upstream.
3333
const packagesDir = join(rootDir, 'vite', 'packages');
3434
const dirs = [
3535
join(rootDir, 'vite'),

0 commit comments

Comments
 (0)