feat(installer): show resolved install locations

Author: fengmk2

.github/workflows/test-standalone-install.yml

@@ -285,7 +285,12 @@ jobs:
           export VP_VPDIRS_AWARE=1
           unset VP_HOME VP_BIN_DIR VP_DATA_DIR VP_CACHE_DIR
           unset XDG_DATA_HOME XDG_CACHE_HOME XDG_CONFIG_HOME XDG_STATE_HOME
-          VP_LOCAL_TGZ="$FAKE_TGZ" VP_VERSION=local-test bash packages/cli/install.sh
+          OUTPUT=$(mktemp)
+          VP_LOCAL_TGZ="$FAKE_TGZ" VP_VERSION=local-test bash packages/cli/install.sh | tee "$OUTPUT"
+
+          grep -F "Install locations:" "$OUTPUT"
+          grep -F "Data directory: ~/.local/share/vite-plus" "$OUTPUT"
+          grep -F "Bin directory:  ~/.local/share/vite-plus/bin" "$OUTPUT"
 
           test ! -d "$FRESH/.vite-plus"
           test -e "$FRESH/.local/share/vite-plus/current"
@@ -457,6 +462,18 @@ jobs:
             Write-Error "Expected the pre-split fallback notice in installer output"
             exit 1
           }
+          if (-not (Select-String -Path install-output.txt -Pattern "Install locations:" -SimpleMatch -Quiet)) {
+            Write-Error "Expected install locations in installer output"
+            exit 1
+          }
+          if (-not (Select-String -Path install-output.txt -Pattern "Data directory: ~\.vite-plus" -SimpleMatch -Quiet)) {
+            Write-Error "Expected the single-root data directory in installer output"
+            exit 1
+          }
+          if (-not (Select-String -Path install-output.txt -Pattern "Bin directory:  ~\.vite-plus\bin" -SimpleMatch -Quiet)) {
+            Write-Error "Expected the single-root bin directory in installer output"
+            exit 1
+          }
 
       - name: Verify monolithic layout
         shell: pwsh
@@ -510,8 +527,10 @@ jobs:
           echo "$output"
           # Verify installation succeeds (not a fatal error)
           echo "$output" | grep -q "successfully installed"
-          # Verify fallback message shows binary location
-          echo "$output" | grep -q "vp was installed to:"
+          # Verify the success message shows the single-root locations
+          echo "$output" | grep -q "Install locations:"
+          echo "$output" | grep -q "Data directory: ~/.vite-plus"
+          echo "$output" | grep -q "Bin directory:  ~/.vite-plus/bin"
           # Verify fallback message shows manual instructions
           echo "$output" | grep -q "Or run vp directly:"
           # Verify the permission warning was shown
@@ -1422,7 +1441,17 @@ jobs:
           New-Item -ItemType Directory -Force -Path $root | Out-Null
           New-Item -ItemType File -Force -Path $env:VP_LOCAL_TGZ | Out-Null
 
-          & ./packages/cli/install.ps1
+          $output = (& ./packages/cli/install.ps1 *>&1) | Out-String
+          Write-Host $output
+          if (-not $output.Contains("Install locations:")) {
+            throw "install.ps1 did not print install locations"
+          }
+          if (-not $output.Contains("Data directory: $($env:VP_DATA_DIR)")) {
+            throw "install.ps1 did not print the split data directory"
+          }
+          if (-not $output.Contains("Bin directory:  $($env:VP_BIN_DIR)")) {
+            throw "install.ps1 did not print the split bin directory"
+          }
 
           function Get-DirMap([string]$VpBinary) {
             $env:VP_DUMP_DIRS = "1"

packages/cli/install.ps1

@@ -1177,9 +1177,10 @@ exec "`$VP_HOME/current/bin/vp.exe" "`$@"
     $pathResult = Configure-UserPath
     $nushellResult = Configure-Nushell
 
-    # Use ~ when the shim directory is under USERPROFILE. Otherwise, show the
+    # Use ~ when an install location is under USERPROFILE. Otherwise, show the
     # full path.
-    $displayDir = $ShimDir -replace [regex]::Escape($env:USERPROFILE), '~'
+    $displayDataDir = $InstallDir -replace [regex]::Escape($env:USERPROFILE), '~'
+    $displayBinDir = $ShimDir -replace [regex]::Escape($env:USERPROFILE), '~'
     $displayConfigDir = $ConfigDir -replace [regex]::Escape($env:USERPROFILE), '~'
 
     # ANSI color codes for consistent output
@@ -1215,6 +1216,11 @@ exec "`$VP_HOME/current/bin/vp.exe" "`$@"
     Write-Host ""
     Write-Host "  Run ${BRIGHT_BLUE}vp help${NC} to see available commands."
 
+    Write-Host ""
+    Write-Host "  ${BOLD}Install locations:${NC}"
+    Write-Host "    Data directory: $displayDataDir"
+    Write-Host "    Bin directory:  $displayBinDir"
+
     Write-Host ""
     Write-Host "  Shell configuration:"
     switch ($pathResult) {
@@ -1238,8 +1244,6 @@ exec "`$VP_HOME/current/bin/vp.exe" "`$@"
         Write-Host ""
         Write-Host "  ${YELLOW}note${NC}: Some shells still need manual setup."
         Write-Host ""
-        Write-Host "  vp was installed to: ${BOLD}${displayDir}${NC}"
-        Write-Host ""
         if ($pathResult -eq "failed") {
             Write-Host "  To use vp in Powershell/cmd, manually add it to your PATH:"
             Write-Host ""

packages/cli/install.sh

@@ -1411,9 +1411,10 @@ WRAPPER_EOF
   # Configure shell PATH after the install is otherwise complete.
   configure_shell_path
 
-  # Use ~ when the shim directory is under HOME. Otherwise, show the full path.
-  local display_location
-  display_location="$(abbreviate_path "$SHIM_DIR")"
+  # Use ~ when an install location is under HOME. Otherwise, show the full path.
+  local display_data_dir display_bin_dir
+  display_data_dir="$(abbreviate_path "$INSTALL_DIR")"
+  display_bin_dir="$(abbreviate_path "$SHIM_DIR")"
 
   # Print success message
   echo ""
@@ -1436,6 +1437,11 @@ WRAPPER_EOF
   echo ""
   echo -e "  Run ${BRIGHT_BLUE}vp help${NC} to see available commands."
 
+  echo ""
+  echo -e "  ${BOLD}Install locations:${NC}"
+  echo "    Data directory: $display_data_dir"
+  echo "    Bin directory:  $display_bin_dir"
+
   echo ""
   echo "  Shell configuration:"
   local summary_line
@@ -1454,8 +1460,6 @@ WRAPPER_EOF
     echo ""
     echo -e "  ${YELLOW}note${NC}: Some shells still need manual setup."
     echo ""
-    echo -e "  vp was installed to: ${BOLD}${display_location}${NC}"
-    echo ""
     echo "  Manual setup instructions:"
     echo "    - Bash/Zsh: add the following to your shell config (~/.bashrc, ~/.zshrc, etc.):"
     printf '        . "%s/env"\n' "$CONFIG_DIR_REF_POSIX"
@@ -1466,7 +1470,7 @@ WRAPPER_EOF
     echo ""
     echo "  Or run vp directly:"
     echo ""
-    echo -e "    ${display_location}/vp"
+    echo -e "    ${display_bin_dir}/vp"
   fi
 
   echo ""