fix(cli): resolve lowercase Windows shims in case-sensitive directories (#2727)

Fixes #2690.

pnpm 12 creates lowercase `.cmd` shims. On Windows, uppercase `PATHEXT`
entries prevent `which` from finding those shims in case-sensitive
directories.

Add uppercase and lowercase variants next to each configured `PATHEXT`
entry when the global CLI or NAPI binding starts. With the default
order, `.EXE` and `.exe` precede `.CMD` and `.cmd`. Vite Task, `fspy`,
and child processes use the same extension order with the published
`which` crate.

Run `windows_case_sensitive_shims` in an isolated NTFS directory on
Windows shard `1`. Other snapshots keep their existing temp-directory
settings.

Author: fengmk2

.github/workflows/ci.yml

@@ -1102,6 +1102,18 @@ jobs:
         with:
           tool: cargo-nextest
 
+      # Keep fixtures outside runner.temp: setup-node writes an .npmrc there,
+      # which Yarn Classic discovers when walking parent directories.
+      - name: Create NTFS temp directory for case-sensitive shim snapshots
+        if: matrix.shard == 1
+        id: snapshot-temp
+        shell: pwsh
+        run: |
+          $volume = [System.IO.Path]::GetPathRoot($env:RUNNER_TEMP)
+          $snapshotTemp = Join-Path $volume ('vp-snapshots-' + [guid]::NewGuid().ToString('N'))
+          New-Item -ItemType Directory -Path $snapshotTemp | Out-Null
+          "directory=$snapshotTemp" >> $env:GITHUB_OUTPUT
+
       # `cargo-nextest` is invoked directly so the job never depends on the
       # runner's Rust toolchain. --workspace-remap makes nextest rewrite
       # CARGO_MANIFEST_DIR and CARGO_BIN_EXE_vpt to this checkout, which is
@@ -1121,7 +1133,20 @@ jobs:
           export VP_SNAP_PWSH_BIN="$(cygpath -w "$(command -v pwsh.exe)")"
           # --no-fail-fast: on a snapshot suite every diff is diagnostic
           # signal; cancelling on the first failure hides the rest.
-          cargo-nextest nextest run --archive-file windows-snapshot-tests.tar.zst --workspace-remap . --no-fail-fast --partition hash:${{ matrix.shard }}/3
+          test_exit=0
+          # This fixture requires case-sensitive directory support, which the
+          # default temp directory on these runners does not provide.
+          cargo-nextest nextest run --archive-file windows-snapshot-tests.tar.zst --workspace-remap . --no-fail-fast --partition hash:${{ matrix.shard }}/3 \
+            -E 'not test(windows_case_sensitive_shims)' || test_exit=$?
+
+          if [[ '${{ matrix.shard }}' == '1' ]]; then
+            # Run both flavors on NTFS once. Rust's GetTempPath2 ignores
+            # TEMP/TMP under the SYSTEM account, so override SystemTemp.
+            SystemTemp='${{ steps.snapshot-temp.outputs.directory }}' \
+              cargo-nextest nextest run --archive-file windows-snapshot-tests.tar.zst --workspace-remap . --no-fail-fast \
+                -E 'test(windows_case_sensitive_shims)' || test_exit=$?
+          fi
+          exit "$test_exit"
         env:
           RUST_BACKTRACE: '1'
           # Keep Windows env parity with the `test` recipe in justfile.

Cargo.lock

@@ -0,0 +1,4 @@
+const fs = require('node:fs');
+
+fs.mkdirSync('node_modules/.bin', { recursive: true });
+fs.writeFileSync('node_modules/.bin/astro.CMD', '@echo wrong workspace shim %*\r\n');

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/later-shim.cjs

@@ -0,0 +1,13 @@
+const { execFileSync } = require('node:child_process');
+const path = require('node:path');
+
+const vp = path.join(path.dirname(require.resolve('vite-plus/package.json')), 'bin', 'vp');
+// The runner's node shim can expand PATHEXT before this script starts.
+// Reset it in a new process that launches real Node directly, so only the
+// NAPI initializer can supply the lowercase extension for this CLI lookup.
+execFileSync(process.execPath, [vp, 'exec', 'astro', '--version'], {
+  cwd: path.resolve('packages/app'),
+  env: { ...process.env, PATHEXT: '.COM;.EXE;.BAT;.CMD' },
+  stdio: 'inherit',
+  timeout: 30000,
+});

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/local-cli.cjs

@@ -0,0 +1,8 @@
+{
+  "name": "case-sensitive-shims",
+  "private": true,
+  "packageManager": "pnpm@12.4.1",
+  "scripts": {
+    "probe": "vp run --filter @fixture/app probe"
+  }
+}

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/package.json

@@ -0,0 +1,8 @@
+{
+  "name": "@fixture/app",
+  "private": true,
+  "scripts": {
+    "probe": "astro --version",
+    "priority": "node-priority -e \"process.exit(0)\""
+  }
+}

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/packages/app/package.json

@@ -0,0 +1 @@
+console.log('local shim', ...process.argv.slice(2));

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/packages/app/print.cjs

@@ -0,0 +1,9 @@
+export default {
+  run: {
+    tasks: {
+      cached: {
+        command: "astro cached",
+      },
+    },
+  },
+};

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/packages/app/vite.config.ts

@@ -0,0 +1,2 @@
+packages:
+  - packages/*

crates/vp_cli_snapshots/tests/cli_snapshots/fixtures/windows_case_sensitive_shims/pnpm-workspace.yaml

@@ -0,0 +1,16 @@
+const assert = require('node:assert/strict');
+const { execFileSync } = require('node:child_process');
+const fs = require('node:fs');
+const path = require('node:path');
+
+const bin = path.resolve('packages/app/node_modules/.bin');
+fs.mkdirSync(bin, { recursive: true });
+// The directory must be empty when case sensitivity is enabled. Do not depend
+// on the checkout's NTFS flags or the casing chosen by a package manager.
+execFileSync('fsutil.exe', ['file', 'setCaseSensitiveInfo', bin, 'enable'], { stdio: 'inherit' });
+fs.writeFileSync(path.join(bin, 'astro.cmd'), '@echo off\r\nnode "%~dp0/../../print.cjs" %*\r\n');
+// A lowercase executable must win over an uppercase command shim in the same directory.
+fs.copyFileSync(process.execPath, path.join(bin, 'node-priority.exe'));
+fs.writeFileSync(path.join(bin, 'node-priority.CMD'), '@echo wrong cmd shim\r\n@exit /b 1\r\n');
+assert.equal(fs.existsSync(path.join(bin, 'astro.CMD')), false);
+assert.ok(process.env.PATHEXT.split(';').includes('.CMD'));