Fixed some inspect code warnings/errors

Author: vmadalin

build.gradle.kts

@@ -16,14 +16,14 @@
 
 import extensions.applyDefault
 
-plugins.apply("git-hooks-config")
-plugins.apply("update-dependencies-config")
+plugins.apply(BuildPlugins.GIT_HOOKS)
+plugins.apply(BuildPlugins.UPDATE_DEPENDENCIES)
 
 allprojects {
     repositories.applyDefault()
 
-    plugins.apply("detekt-config")
-    plugins.apply("dokka-config")
-    plugins.apply("ktlint-config")
-    plugins.apply("spotless-config")
+    plugins.apply(BuildPlugins.DETEKT)
+    plugins.apply(BuildPlugins.DOKKA)
+    plugins.apply(BuildPlugins.KTLINT)
+    plugins.apply(BuildPlugins.SPOTLESS)
 }

buildSrc/src/main/kotlin/BuildPlugins.kt

@@ -28,8 +28,13 @@ object BuildPlugins {
     const val KOTLIN_ALLOPEN = "kotlin-allopen"
 
     const val NAVIGATION_SAFE_ARGS = "androidx.navigation.safeargs.kotlin"
-    const val SPOTLESS = "com.diffplug.gradle.spotless"
-    const val DETEKT = "io.gitlab.arturbosch.detekt"
     const val JACOCO = "com.vanniktech.android.junit.jacoco"
     const val FABRIC = "io.fabric"
+
+    const val DETEKT = "plugins.detekt"
+    const val DOKKA = "plugins.dokka"
+    const val GIT_HOOKS = "plugins.git-hooks"
+    const val KTLINT = "plugins.ktlint"
+    const val SPOTLESS = "plugins.spotless"
+    const val UPDATE_DEPENDENCIES = "plugins.update-dependencies"
 }

buildSrc/src/main/kotlin/scripts/detekt-config.gradle.kts renamed to buildSrc/src/main/kotlin/plugins/detekt.gradle.kts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+package plugins
+
 import io.gitlab.arturbosch.detekt.DetektPlugin
 import io.gitlab.arturbosch.detekt.extensions.DetektExtension
 

buildSrc/src/main/kotlin/scripts/dokka-config.gradle.kts renamed to buildSrc/src/main/kotlin/plugins/dokka.gradle.kts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+package plugins
+
 import org.jetbrains.dokka.gradle.DokkaPlugin
 import org.jetbrains.dokka.gradle.DokkaTask
 

buildSrc/src/main/kotlin/scripts/git-hooks-config.gradle.kts renamed to buildSrc/src/main/kotlin/plugins/git-hooks.gradle.kts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+package plugins
+
 import utils.isLinuxOrMacOs
 
 tasks {

buildSrc/src/main/kotlin/scripts/ktlint-config.gradle.kts renamed to buildSrc/src/main/kotlin/plugins/ktlint.gradle.kts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+package plugins
+
 val ktlint: Configuration by configurations.creating
 
 dependencies {

buildSrc/src/main/kotlin/scripts/spotless-config.gradle.kts renamed to buildSrc/src/main/kotlin/plugins/spotless.gradle.kts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+package plugins
+
 import com.diffplug.gradle.spotless.SpotlessExtension
 import com.diffplug.gradle.spotless.SpotlessPlugin
 
@@ -71,7 +73,7 @@ configure<SpotlessExtension> {
         target("**/*.gradle.kts", "*.gradle.kts")
         licenseHeaderFile(
             rootProject.file("COPYRIGHT"),
-            "import|tasks|apply|plugins|include|val|object|interface"
+            "package|import|tasks|apply|plugins|include|val|object|interface"
         )
         trimTrailingWhitespace()
         indentWithSpaces()

buildSrc/src/main/kotlin/scripts/update-dependencies-config.gradle.kts renamed to buildSrc/src/main/kotlin/plugins/update-dependencies.gradle.kts

@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+package plugins
+
 import com.github.benmanes.gradle.versions.VersionsPlugin
 import com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask
 

buildSrc/src/main/kotlin/utils/CrashlyticsUtils.kt

@@ -19,7 +19,6 @@ package utils
 import org.gradle.api.Project
 import java.io.File
 import java.lang.Exception
-import extensions.getLocalProperty
 
 private const val FABRIC_PROPERTIES_FILE_NAME = "app/fabric.properties"
 private const val FABRIC_API_KEY_PROPERTY_NAME = "fabric.key"

core/src/main/AndroidManifest.xml

@@ -1,2 +1 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.vmadalin.core" />
+<manifest package="com.vmadalin.core" />

core/src/main/kotlin/com/vmadalin/core/network/NetworkState.kt

@@ -32,7 +32,7 @@ sealed class NetworkState {
         val isAdditional: Boolean = false
     ) : NetworkState()
 
-    fun isLoading() = this is NetworkState.Loading
-    fun isSuccess() = this is NetworkState.Success
-    fun isError() = this is NetworkState.Error
+    fun isLoading() = this is Loading
+    fun isSuccess() = this is Success
+    fun isError() = this is Error
 }