Removed deprecated fabric #2 (#28)

* Remove deprecated fabric
* Pointing circleCI docker image to specific sha

Author: vmadalin

.circleci/config.yml

@@ -7,20 +7,14 @@ jobs:
   build:
     working_directory: ~/kotlin-sample-app
     docker:
-      - image: circleci/android:api-28
+      - image: circleci/android@sha256:b6646fdf7457f61825526e7bfce364d8e533da6ceb1cdb98e371e94348ecc834
     environment:
       GRADLE_OPTS: -Xmx4g -Dorg.gradle.daemon=false
       JVM_OPTS: -Xmx4g
     steps:
       - checkout
-      - run: echo "fabric.key=$FABRIC_KEY" >> local.properties
-      - run: echo "fabric.secret=$FABRIC_SECRET" >> local.properties
       - run: echo "marvel.key.public=$MARVEL_KEY_PUBLIC" >> local.properties
       - run: echo "marvel.key.private=$MARVEL_KEY_PRIVATE" >> local.properties
-      - run: echo "signing.key.alias=$SIGNING_KEY_ALIAS" >> local.properties
-      - run: echo "signing.key.password=$SIGNING_KEY_PASSWORD" >> local.properties
-      - run: echo "signing.store.file=$SIGNING_STORE_FILE" >> local.properties
-      - run: echo "signing.store.password=$SIGNING_STORE_PASSWORD" >> local.properties
       - restore_cache:
           key: gradle-{{ checksum "build.gradle.kts" }}
       - run:
@@ -31,7 +25,7 @@ jobs:
           command: ./gradlew ktlint
       - run:
           name: Run Lint
-          command: ./gradlew lintDevDebug
+          command: ./gradlew lintDevDebug --stacktrace
       - run:
           name: Run Spotless
           command: ./gradlew spotlessKotlinCheck

.gitignore

@@ -35,13 +35,7 @@ captures/
 
 # IntelliJ
 *.iml
-.idea/workspace.xml
-.idea/tasks.xml
-.idea/gradle.xml
-.idea/assetWizardSettings.xml
-.idea/dictionaries
-.idea/libraries
-.idea/caches
+.idea/
 
 # Keystore files
 *.keystore
@@ -64,6 +58,3 @@ fastlane/Preview.html
 fastlane/screenshots
 fastlane/test_output
 fastlane/readme.md
-
-# Fabric
-Fabric.properties

README.md

@@ -49,31 +49,14 @@ The project received different mentions/reference from Android Developer Communi
 
 First off, you require the latest Android Studio 3.5.3 (or newer) to be able to build the app.
 
-You need to supply API keys for the various services the app uses. That is currently Marvel and Fabric (Crashlytics). You can find information about how to gain access via these relevant links.
-
--   Marvel: https://developer.marvel.com/
--   Firebase: https://get.fabric.io/
+You need to supply keys for Marvel API. You can find information about how to gain access by using the [link](https://developer.marvel.com).
 
 When you obtain the keys, you can provide them to the app by putting the following in the `local.properties` project root file:
 
 ```properties
 #Marvel API KEYS
 marvel.key.public = <insert>
 marvel.key.private = <insert>
-
-#Fabric API KEYS
-fabric.key = <insert>
-fabric.secret = <insert>
-```
-
-Moreover, to sign your app for release you should generate an upload key and keystore following the [official documentation](https://developer.android.com/studio/publish/app-signing#sign-apk). Append the information used to generate it into `local.properties` project root file following the structure:
-
-```properties
-#Signing Config
-signing.key.alias = <insert>
-signing.key.password = <insert>
-signing.store.file = <insert>
-signing.store.password = <insert>
 ```
 
 ### Code style

app/build.gradle.kts

@@ -14,15 +14,12 @@
  * limitations under the License.
  */
 
-import utils.createFabricProperties
 import dependencies.Dependencies
 import dependencies.DebugDependencies
 import dependencies.AnnotationProcessorsDependencies
 import extensions.addTestsDependencies
 import extensions.implementation
 import extensions.debugImplementation
-import extensions.getLocalProperty
-import extensions.buildConfigBooleanField
 import extensions.kapt
 
 plugins {
@@ -34,7 +31,6 @@ plugins {
     id(BuildPlugins.NAVIGATION_SAFE_ARGS)
     id(BuildPlugins.JACOCO)
     id(BuildPlugins.GRAPH_GENERATOR)
-    id(BuildPlugins.FABRIC)
 }
 
 allOpen {
@@ -58,32 +54,18 @@ android {
         testInstrumentationRunnerArguments = BuildAndroidConfig.TEST_INSTRUMENTATION_RUNNER_ARGUMENTS
     }
 
-    signingConfigs {
-        create(BuildType.RELEASE) {
-            keyAlias = getLocalProperty("signing.key.alias")
-            keyPassword = getLocalProperty("signing.key.password")
-            storeFile = file(getLocalProperty("signing.store.file"))
-            storePassword = getLocalProperty("signing.store.password")
-        }
-    }
-
     buildTypes {
         getByName(BuildType.RELEASE) {
             proguardFiles("proguard-android-optimize.txt", "proguard-rules.pro")
-            signingConfig = signingConfigs.getByName(name)
-
             isMinifyEnabled = BuildTypeRelease.isMinifyEnabled
             isTestCoverageEnabled = BuildTypeRelease.isTestCoverageEnabled
-            buildConfigBooleanField("ENABLE_CRASHLYTICS", BuildTypeRelease.isCrashlyticsEnabled)
         }
 
         getByName(BuildType.DEBUG) {
             applicationIdSuffix = BuildTypeDebug.applicationIdSuffix
             versionNameSuffix = BuildTypeDebug.versionNameSuffix
             isMinifyEnabled = BuildTypeDebug.isMinifyEnabled
             isTestCoverageEnabled = BuildTypeDebug.isTestCoverageEnabled
-
-            buildConfigBooleanField( "ENABLE_CRASHLYTICS", BuildTypeDebug.isCrashlyticsEnabled)
         }
     }
 
@@ -145,10 +127,6 @@ junitJacoco {
     includeNoLocationClasses = true
 }
 
-afterEvaluate {
-    createFabricProperties(this)
-}
-
 dependencies {
     implementation(project(BuildModules.CORE))
 
@@ -159,7 +137,6 @@ dependencies {
     implementation(Dependencies.NAVIGATION_FRAGMENT)
     implementation(Dependencies.TIMBER)
     implementation(Dependencies.LOGGING)
-    implementation(Dependencies.CRASHLYTICS)
     implementation(Dependencies.PLAY_CORE)
     implementation(Dependencies.DAGGER)
 

app/src/main/kotlin/com/vmadalin/android/SampleApp.kt

@@ -17,14 +17,12 @@
 package com.vmadalin.android
 
 import android.content.Context
-import com.crashlytics.android.Crashlytics
 import com.google.android.play.core.splitcompat.SplitCompatApplication
 import com.vmadalin.android.di.DaggerAppComponent
 import com.vmadalin.core.di.CoreComponent
 import com.vmadalin.core.di.DaggerCoreComponent
 import com.vmadalin.core.di.modules.ContextModule
 import com.vmadalin.core.utils.ThemeUtils
-import io.fabric.sdk.android.Fabric
 import javax.inject.Inject
 import kotlin.random.Random
 import timber.log.Timber
@@ -62,7 +60,6 @@ class SampleApp : SplitCompatApplication() {
     override fun onCreate() {
         super.onCreate()
         initTimber()
-        initFabric()
         initCoreDependencyInjection()
         initAppDependencyInjection()
         initRandomNightMode()
@@ -102,15 +99,6 @@ class SampleApp : SplitCompatApplication() {
         }
     }
 
-    /**
-     * Initialize crash report library Fabric on non debug build.
-     */
-    private fun initFabric() {
-        if (!BuildConfig.DEBUG) {
-            Fabric.with(this, Crashlytics())
-        }
-    }
-
     /**
      * Initialize random nightMode to make developer aware of day/night themes.
      */

buildSrc/build.gradle.kts

@@ -25,7 +25,6 @@ repositories {
     jcenter()
     mavenCentral()
     maven("https://oss.sonatype.org/content/repositories/snapshots")
-    maven("https://maven.fabric.io/public")
     maven("https://plugins.gradle.org/m2/")
     maven("https://ci.android.com/builds/submitted/5837096/androidx_snapshot/latest/repository")
 }
@@ -40,7 +39,6 @@ object PluginsVersions {
     const val KOTLIN = "1.3.61"
     const val NAVIGATION = "2.1.0"
     const val JACOCO = "0.16.0"
-    const val FABRIC = "1.31.2"
     const val DOKKA = "0.10.0"
     const val KTLINT = "0.36.0"
     const val SPOTLESS = "3.26.1"
@@ -56,7 +54,6 @@ dependencies {
     implementation("androidx.navigation:navigation-safe-args-gradle-plugin:${PluginsVersions.NAVIGATION}")
     implementation("com.vanniktech:gradle-android-junit-jacoco-plugin:${PluginsVersions.JACOCO}")
     implementation("com.vanniktech:gradle-dependency-graph-generator-plugin:${PluginsVersions.GRAPH_GENERATOR}")
-    implementation("io.fabric.tools:gradle:${PluginsVersions.FABRIC}")
     implementation("org.jetbrains.dokka:dokka-gradle-plugin:${PluginsVersions.DOKKA}")
     implementation("com.pinterest:ktlint:${PluginsVersions.KTLINT}")
     implementation("com.diffplug.spotless:spotless-plugin-gradle:${PluginsVersions.SPOTLESS}")

buildSrc/src/main/kotlin/BuildDependenciesVersions.kt

@@ -37,7 +37,6 @@ object BuildDependenciesVersions {
     const val LOGGING = "4.2.2"
     const val MOSHI = "1.9.2"
     const val COIL = "0.8.0"
-    const val CRASHLYTICS = "2.10.1"
     const val PLAY_CORE = "1.6.4"
     const val LEAKCANARY = "2.0"
     const val DATABINDING = "3.1.4"

buildSrc/src/main/kotlin/BuildPlugins.kt

@@ -30,7 +30,6 @@ object BuildPlugins {
     const val NAVIGATION_SAFE_ARGS = "androidx.navigation.safeargs.kotlin"
     const val JACOCO = "com.vanniktech.android.junit.jacoco"
     const val GRAPH_GENERATOR = "com.vanniktech.dependency.graph.generator"
-    const val FABRIC = "io.fabric"
 
     const val DETEKT = "plugins.detekt"
     const val DOKKA = "plugins.dokka"

buildSrc/src/main/kotlin/BuildTypes.kt

@@ -22,13 +22,11 @@ interface BuildType {
     }
 
     val isMinifyEnabled: Boolean
-    val isCrashlyticsEnabled: Boolean
     val isTestCoverageEnabled: Boolean
 }
 
 object BuildTypeDebug : BuildType {
     override val isMinifyEnabled = false
-    override val isCrashlyticsEnabled = false
     override val isTestCoverageEnabled = true
 
     const val applicationIdSuffix = ".debug"
@@ -37,6 +35,5 @@ object BuildTypeDebug : BuildType {
 
 object BuildTypeRelease : BuildType {
     override val isMinifyEnabled = true
-    override val isCrashlyticsEnabled = true
     override val isTestCoverageEnabled = false
 }

buildSrc/src/main/kotlin/dependencies/Dependencies.kt

@@ -46,6 +46,5 @@ object Dependencies {
     const val MOSHI = "com.squareup.moshi:moshi:${BuildDependenciesVersions.MOSHI}"
     const val MOSHI_KTX = "com.squareup.moshi:moshi-kotlin:${BuildDependenciesVersions.MOSHI}"
     const val COIL = "io.coil-kt:coil:${BuildDependenciesVersions.COIL}"
-    const val CRASHLYTICS = "com.crashlytics.sdk.android:crashlytics:${BuildDependenciesVersions.CRASHLYTICS}"
     const val PLAY_CORE = "com.google.android.play:core:${BuildDependenciesVersions.PLAY_CORE}"
 }