Merge pull request #3 from VMadalin/mv/add-tests-coverage

Add test coverage for :commons:ui and :core modules

Author: vmadalin

.detekt/config.yml

@@ -42,13 +42,15 @@ comments:
     active: false
     endOfSentenceFormat: ([.?!][ \t\n\r\f<])|([.?!:]$)
   UndocumentedPublicClass:
-    active: false
+    active: true
+    excludes: "**/test_utils/**"
     searchInNestedClass: true
     searchInInnerClass: true
     searchInInnerObject: true
     searchInInnerInterface: true
   UndocumentedPublicFunction:
-    active: false
+    active: true
+    excludes: "**/test_utils/**"
   UndocumentedPublicProperty:
     active: false
 

README.md

@@ -110,7 +110,7 @@ The architecture of the application is based, apply and strictly complies with e
 <img src="screenshots/architecture/project_structure.png" width="300" align="right" hspace="20">
 
 -   A single-activity architecture, using the [Navigation component](https://developer.android.com/guide/navigation/navigation-getting-started) to manage fragment operations.
--   [Android architecture components](https://developer.android.com/topic/libraries/architecture/), part of Android Jetpack for give to project a robust design, testable and maintainable. 
+-   [Android architecture components](https://developer.android.com/topic/libraries/architecture/), part of Android Jetpack for give to project a robust design, testable and maintainable.
 -   Pattern [Model-View-ViewModel](https://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93viewmodel) (MVVM) facilitating a [separation](https://en.wikipedia.org/wiki/Separation_of_concerns) of development of the graphical user interface.
 -   [S.O.L.I.D](https://en.wikipedia.org/wiki/SOLID) design principles intended to make software designs more understandable, flexible and maintainable.
 -   [Modular app architecture](https://proandroiddev.com/build-a-modular-android-app-architecture-25342d99de82) allows to be developed features in isolation, independently from other features.
@@ -139,7 +139,7 @@ The `:core` module is an [com.android.library](https://developer.android.com/st
 
 #### Features modules
 
-The `:features` module are an [com.android.dynamic-feature](https://developer.android.com/studio/projects/dynamic-delivery) is essentially a gradle module which can be downloaded independently from the base application module. It can hold code and resources and include dependencies, just like any other gradle module. 
+The `:features` module are an [com.android.dynamic-feature](https://developer.android.com/studio/projects/dynamic-delivery) is essentially a gradle module which can be downloaded independently from the base application module. It can hold code and resources and include dependencies, just like any other gradle module.
 
 #### Commons modules
 

commons/ui/src/main/kotlin/com/vmadalin/commons/ui/base/BaseFragment.kt

@@ -44,7 +44,14 @@ abstract class BaseFragment<B : ViewDataBinding, M : ViewModel>(
     lateinit var viewModel: M
     lateinit var viewBinding: B
 
+    /**
+     * Called to initialize dagger injection dependency graph when fragment is attached.
+     */
     abstract fun onInitDependencyInjection()
+
+    /**
+     * Called to Initialize view data binding variables when fragment view is created.
+     */
     abstract fun onInitDataBinding()
 
     /**

commons/ui/src/main/kotlin/com/vmadalin/commons/ui/recyclerview/RecyclerViewItemDecoration.kt

@@ -23,6 +23,7 @@ import androidx.annotation.VisibleForTesting.PRIVATE
 import androidx.recyclerview.widget.GridLayoutManager
 import androidx.recyclerview.widget.LinearLayoutManager
 import androidx.recyclerview.widget.RecyclerView
+import kotlin.math.ceil
 
 /**
  * Simple item decoration allows the application to add a special drawing and layout offset
@@ -85,7 +86,7 @@ class RecyclerViewItemDecoration(
         itemCount: Int
     ) {
         val cols = layoutManager.spanCount
-        val rows = if (itemCount % 2 == 0) itemCount / cols else itemCount / cols + 1
+        val rows = ceil(itemCount / cols.toDouble()).toInt()
 
         outRect.top = spacingPx
         outRect.left = spacingPx

commons/ui/src/test/kotlin/com/vmadalin/commons/ui/extensions/ContextExtensionsTest.kt

@@ -0,0 +1,54 @@
+/*
+ * Copyright 2019 vmadalin.com
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.vmadalin.commons.ui.extensions
+
+import android.content.Context
+import io.mockk.MockKAnnotations
+import io.mockk.every
+import io.mockk.impl.annotations.MockK
+import org.junit.Assert.assertEquals
+import org.junit.Before
+import org.junit.Test
+
+class ContextExtensionsTest {
+
+    @MockK(relaxed = true)
+    lateinit var context: Context
+
+    @Before
+    fun setUp() {
+        MockKAnnotations.init(this)
+    }
+
+    @Test
+    fun getString_WhenIdIsNonNull_ReturnResource() {
+        val resId = 0
+        val expectedString = "test"
+
+        every { context.getString(any()) } returns expectedString
+
+        assertEquals(expectedString, context.getString(resId))
+    }
+
+    @Test
+    fun getString_WhenIdIsNull_ReturnEmpty() {
+        val resId = null
+        val expectedString = ""
+
+        assertEquals(expectedString, context.getString(resId))
+    }
+}