[FIX_FOR_VLLM_LATEST] fix issue introduced by PR25896 and comment out still failing tests #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chendi Xue <[email protected]>
Signed-off-by: Chendi Xue <[email protected]>
Signed-off-by: Chendi Xue <[email protected]>
xuechendi
requested review from
adobrzyn,
afierka-intel,
kzawora-intel,
mgawarkiewicz-intel,
mswiniarsk and
vivekgoe
as code owners
✅ CI PassedAll checks passed successfully against the following vllm commit: |
|
Merge fix for 25896 firstly, PD failing is due vllm-project/vllm#25902, will open another PR for fixing |
iboiko-habana
pushed a commit
to iboiko-habana/vllm-gaudi
that referenced
this pull request
Oct 2, 2025
… still failing tests (vllm-project#292) vllm-project/vllm#25896 --------- Signed-off-by: Chendi Xue <[email protected]> Signed-off-by: Iryna Boiko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vllm-project/vllm#25896