Skip to content

Fix auto-merge, now even e2e_test failed, PR still can be auto-merged #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix auto-merge, now even e2e_test failed, PR still can be auto-merged #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e6f821
Fix auto-merge, now even e2e_test failed, PR still can be auto-merged
xuechendi Sep 23, 2025
f821dd4
add merge gate in seperate file
xuechendi Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/auto-merge-gatekeepser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Auto Merge gatekeeper

on:
workflow_run:
# List the workflow files you want to check
workflows: ["pre-commit", "Basic HPU test suite"]
types:
- completed

jobs:
auto-merge-gatekeeper:
runs-on: ubuntu-latest
# This job runs only if the triggering workflow was successful
if: ${{ github.event.workflow_run.conclusion == 'success' }}
steps:
- run: echo "All CI jobs passed."
8 changes: 4 additions & 4 deletions .github/workflows/pre-merge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Basic HPU test suite
name: Basic HPU test suite

on:
pull_request:
Expand Down Expand Up @@ -195,9 +195,9 @@ jobs:
echo "Test script exited with code: $EXITCODE"

pre_merge_hpu_test:
runs-on: ucb-vllm-cicd-g2
needs: [hpu_unit_tests, hpu_e2e_tests, hpu_perf_tests]
runs-on: ubuntu-latest
needs: [hpu_unit_tests, hpu_e2e_tests, hpu_perf_tests, hpu_dp_tests, hpu_pd_tests]
# This job is required to pass for pre-merge CI. By itself it does nothing, and will only pass if all jobs specified in "needs" list pass.
steps:
- name: Succeeded if all previous jobs passed
run: echo "All previous jobs passed."
run: echo "All previous jobs passed."