make the data sent metric safe against NaN

Signed-off-by: Andres Taylor <[email protected]>

Author: systay

src/cmd/vtbenchstat/vtbenchstat.go

@@ -190,29 +190,25 @@ func compareTraces(file1, file2 TraceFile) {
 	for query := range allQueries {
 		s1, ok1 := summary1[query]
 		s2, ok2 := summary2[query]
-
+		if !(ok1 && ok2) {
+			continue
+		}
 		totalQueries++
 
 		printQuery(query, termWidth)
 		table := tablewriter.NewWriter(os.Stdout)
 		table.SetHeader([]string{"Metric", file1.Name, file2.Name, "Diff", "% Change"})
 		table.SetAutoFormatHeaders(false)
 
-		if ok1 && ok2 {
-			routeCallsChange := compareMetric(table, "Route Calls", s1.RouteCalls, s2.RouteCalls)
-			dataSentChange := compareMetric(table, "Rows Sent", s1.RowsSent, s2.RowsSent)
+		routeCallsChange := compareMetric(table, "Route Calls", s1.RouteCalls, s2.RouteCalls)
+		dataSentChange := compareMetric(table, "Rows Sent", s1.RowsSent, s2.RowsSent)
 
-			totalRouteCallsChange += routeCallsChange
+		totalRouteCallsChange += routeCallsChange
+		if !math.IsNaN(dataSentChange) {
 			totalDataSentChange += dataSentChange
+		}
 
-			if math.Abs(routeCallsChange) > significantChangeThreshold || math.Abs(dataSentChange) > significantChangeThreshold {
-				significantChanges++
-			}
-		} else if ok1 {
-			addMissingMetrics(table, s1.RouteCalls, s1.RowsSent)
-			significantChanges++
-		} else if ok2 {
-			addMissingMetrics(table, s2.RouteCalls, s2.RowsSent)
+		if math.Abs(routeCallsChange) > significantChangeThreshold || math.Abs(dataSentChange) > significantChangeThreshold {
 			significantChanges++
 		}